Conversation
This is required for topology awareness scheduling
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/M
|
|
||
| ## Enabling features | ||
| Some of the features discussed here may be at different stages (alpha, beta, or GA). Ensure that the feature you want to try is enabled for the Kubernetes release you are using. To avoid version mismatch, you can enable all of the features discussed here with: | ||
| Some of the features discussed here may be at different stages (alpha, beta, or GA). Ensure that the feature you want to try is enabled for the Kubernetes release you are using. To avoid version mismatch, you can enable all of the features discussed here for both kubelet and kube-apiserver with: |
There was a problem hiding this comment.
Maybe replace it with "across all Kubernetes components" to be safe? Is it common to have different feature gates across components in the same cluster?
There was a problem hiding this comment.
"across all kubernetes components" is a vague and much broader term to me (it includes kube-scheduler, controller-manager, kube-proxy, etc). Especially for new people, they might not even know what are all the components. How about we keep it explicit as it is for now?
There was a problem hiding this comment.
OK. My original concern was we have to remember to update this comment if we end up depending on a flag in controller-manager, for example, but the likelihood of that is probably low.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan, lpabon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 participants
For: