Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Moved kubeflow-pipelines-samples-v2 to GitHub Actions #11048

Merged

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Jul 29, 2024

Description of your changes:
Moved kubeflow-pipelines-samples-v2 to GitHub Actions.

Resolves: #11054

PR to update GoogleCloudPlatform/oss-test-infra

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@hbelmiro hbelmiro force-pushed the kubeflow-pipelines-samples-v2-gha branch 2 times, most recently from df17f38 to 0c2d3ca Compare July 30, 2024 20:19
@hbelmiro hbelmiro force-pushed the kubeflow-pipelines-samples-v2-gha branch from 0c2d3ca to 7f757b0 Compare July 30, 2024 20:37
@hbelmiro hbelmiro changed the title WIP - Kubeflow pipelines samples v2 gha Kubeflow pipelines samples v2 gha Jul 30, 2024
@hbelmiro hbelmiro force-pushed the kubeflow-pipelines-samples-v2-gha branch from 7f757b0 to 181fa00 Compare July 30, 2024 20:56
@hbelmiro hbelmiro marked this pull request as ready for review July 30, 2024 21:18
Copy link

@hbelmiro: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-upgrade-test 181fa00 link false /test kubeflow-pipeline-upgrade-test
kubeflow-pipelines-samples-v2 181fa00 link false /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hbelmiro
Copy link
Contributor Author

@chensun @DharmitD can you guys PTAL?

@hbelmiro hbelmiro changed the title Kubeflow pipelines samples v2 gha test: Moved kubeflow-pipelines-samples-v2 to GitHub Actions Jul 30, 2024
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 87184fd into kubeflow:master Jul 31, 2024
8 of 10 checks passed
@hbelmiro hbelmiro deleted the kubeflow-pipelines-samples-v2-gha branch July 31, 2024 12:31
hbelmiro added a commit to hbelmiro/data-science-pipelines that referenced this pull request Aug 5, 2024
hbelmiro added a commit to hbelmiro/data-science-pipelines that referenced this pull request Aug 5, 2024
droctothorpe pushed a commit to droctothorpe/pipelines that referenced this pull request Aug 13, 2024
R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move kubeflow-pipelines-samples-v2 to GitHub Actions
2 participants