Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(samples/contrib/modular_exponentiation_quantum_circuit) #10949

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Rhm-B-WT
Copy link

Create an example of modular exponentiation quantum circuit in kubflow pipeline

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ark-kun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @Rhm-B-WT. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rimolive
Copy link
Member

/ok-to-test

Copy link

@Rhm-B-WT: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 bc49b46 link false /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Rhm-B-WT
Copy link
Author

I've tested the code on kubeflow and it worked. The AttributeError said "module 'kfp_server_api' has no attribute 'ApiGetHealthzResponse'". The environment I used is python 3.11.7. How can I fix it?

@hbelmiro
Copy link
Contributor

I've tested the code on kubeflow and it worked. The AttributeError said "module 'kfp_server_api' has no attribute 'ApiGetHealthzResponse'". The environment I used is python 3.11.7. How can I fix it?

@Rhm-B-WT I'm migrating the kubeflow-pipelines-samples-v2 tests to GitHub Actions and facing this issue too. When I complete this migration the problem should be fixed.

It would be nice to have a test for this new sample you're adding. However, since the existing tests are not working, we need to wait for the migration to GitHub Actions.

Can we put this PR on hold in the meantime?

/hold

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rhm-B-WT now that we have tests for samples, can you please add a test for this?

@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Sep 11, 2024
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rhm-B-WT you don't need to create any scripts to run the test. You just need to add your test to

test_cases: List[TestCase] = [

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants