-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(pipeline/samples/contrib/QPE_pipeline_example): a pipeline example about QPE #10947
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Henry551 <[email protected]>
Hi @Henry551. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@Henry551: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@rimolive :The code I've tested on kubeflow and it worked. I see the AttributeError in the test and said: module 'kfp_server_api' has no attribute 'ApiGetHealthzResponse', but the environment I use is python=3.11.7, how can I fix it? |
@Henry551 I'm migrating the It would be nice to have a test for this new sample you're adding. However, since the existing tests are not working, we need to wait for the migration to GitHub Actions. Can we put this PR on hold in the meantime? /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Henry551 now that we have tests for samples, can you please add a test for this?
@hbelmiro How could I add test for this? Should I add a Github Action? |
No. You should add a new test case here: https://github.com/kubeflow/pipelines/blob/0d098db41c09c5b65c374f4e110d188b982f544b/samples/v2/sample_test.py And please rebase your PR to get the latest changes on CI :) |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Henry551 Please sign-off your commits |
Pull Request: Add Quantum Phase Estimation (QPE) Pipeline
This PR is about a Kubeflow pipeline for running the Quantum Phase Estimation (QPE) algorithm using Qiskit. The pipeline is designed to leverage the power of quantum computing for estimating the phases of eigenvalues.