feat(Backend + SDK): Update kfp backend and kubernetes sdk to support ImagePullPolicy #10417

revit13 · 2024-01-21T09:15:55Z

Description of your changes:
Part of Part of #9714 and #9980

Update kfp backend and kubernetes sdk to support image pull policy.
To be rebased and update go.mod after #10416

Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

google-cla · 2024-01-21T09:15:59Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-oss-prow · 2024-01-21T09:16:06Z

Hi @revit13. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Tomcli · 2024-01-22T16:52:34Z

rebase and update go.mod after #10416

Tomcli · 2024-02-07T18:32:59Z

/ok-to-test

Tomcli

@revit13 Can you update the go.mod and the related files like in this PR? Thanks.
#10427 (review)

zijianjoy · 2024-02-08T23:39:54Z

/assign @chensun
/assign @connor-mccarthy

Tomcli · 2024-02-12T19:08:52Z

backend/src/v2/driver/driver.go

@@ -475,6 +475,12 @@ func extendPodSpecPatch(
 		podSpec.Containers[0].VolumeMounts = append(podSpec.Containers[0].VolumeMounts, volumeMounts...)
 	}

+	// Get image pull policy
+	if kubernetesExecutorConfig.GetImagePullPolicy() != "" {


Maybe we can also set kubernetesExecutorConfig.GetImagePullPolicy() as a variable, then check whether the value is one of ['Always', 'Never', 'IfNotPresent']?

There could be a case where someone can compose the IR without the SDK, so we also want to check the value is valid before passing into the pod spec. If the value is not valid, we should raise an error instead.

@Tomcli Done. Thanks

… ImagePullPolicy. Signed-off-by: Revital Sur <[email protected]>

Signed-off-by: Revital Sur <[email protected]>

Tomcli

/lgtm

Tomcli · 2024-02-26T17:08:01Z

/assign @chensun

chensun · 2024-03-05T18:19:18Z

@revit13 Can you please rebase and resolve the conflicts?

Signed-off-by: Revital Sur <[email protected]>

revit13 · 2024-03-05T21:02:31Z

@revit13 Can you please rebase and resolve the conflicts?

@chensun Done, Thanks

chensun

/lgtm
/approve

chensun · 2024-03-05T21:34:55Z

kubernetes_platform/python/kfp/kubernetes/image.py

+
+    Args:
+        task: Pipeline task.
+        policy: One of `Always`, `Never`, `IfNotPresent`.


nit: using enum could be less error-prone, and also works with IDE code auto-complete. No strong preference though.

google-oss-prow · 2024-03-05T21:35:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [chensun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2024-03-05T21:52:44Z

@revit13: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
kubeflow-pipelines-samples-v2	`09fbe3e`	link	false	`/test kubeflow-pipelines-samples-v2`
kfp-kubernetes-execution-tests	`09fbe3e`	link	false	`/test kfp-kubernetes-execution-tests`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

… ImagePullPolicy (kubeflow#10417) * feat(Backend + SDK): Update kfp backend and kubernetes sdk to support ImagePullPolicy. Signed-off-by: Revital Sur <[email protected]> * Fix format. Signed-off-by: Revital Sur <[email protected]> * Update apiserver.csv. Signed-off-by: Revital Sur <[email protected]> * Update licenses. Signed-off-by: Revital Sur <[email protected]> --------- Signed-off-by: Revital Sur <[email protected]>

google-oss-prow bot requested review from connor-mccarthy and gkcalat January 21, 2024 09:15

revit13 marked this pull request as draft January 21, 2024 09:16

google-oss-prow bot added do-not-merge/work-in-progress size/L needs-ok-to-test labels Jan 21, 2024

revit13 force-pushed the patch2 branch 2 times, most recently from cf362ca to 1aa7791 Compare January 22, 2024 08:28

revit13 mentioned this pull request Feb 1, 2024

feat(kubernetes_platform): Update kubernetes_platform go package to include imagePullPolicy. #10416

Merged

1 task

google-oss-prow bot added ok-to-test and removed needs-ok-to-test labels Feb 7, 2024

Tomcli suggested changes Feb 7, 2024

View reviewed changes

revit13 force-pushed the patch2 branch from 7ab6a6b to b0a3658 Compare February 8, 2024 09:08

revit13 marked this pull request as ready for review February 8, 2024 09:08

google-oss-prow bot removed the do-not-merge/work-in-progress label Feb 8, 2024

google-oss-prow bot requested a review from chensun February 8, 2024 09:08

google-oss-prow bot assigned chensun and connor-mccarthy Feb 8, 2024

Tomcli reviewed Feb 12, 2024

View reviewed changes

feat(Backend + SDK): Update kfp backend and kubernetes sdk to support…

9616ad7

… ImagePullPolicy. Signed-off-by: Revital Sur <[email protected]>

revit13 force-pushed the patch2 branch from b0a3658 to 9616ad7 Compare February 25, 2024 10:17

revit13 added 2 commits February 25, 2024 04:32

Fix format.

3c30bce

Signed-off-by: Revital Sur <[email protected]>

Update apiserver.csv.

f52828e

Signed-off-by: Revital Sur <[email protected]>

Tomcli reviewed Feb 26, 2024

View reviewed changes

google-oss-prow bot assigned Tomcli Feb 26, 2024

google-oss-prow bot added the lgtm label Feb 26, 2024

Merge branch 'master' into patch2

bb0438d

google-oss-prow bot removed the lgtm label Mar 5, 2024

Update licenses.

09fbe3e

Signed-off-by: Revital Sur <[email protected]>

chensun approved these changes Mar 5, 2024

View reviewed changes

google-oss-prow bot added the lgtm label Mar 5, 2024

google-oss-prow bot added the approved label Mar 5, 2024

google-oss-prow bot merged commit 83cabab into kubeflow:master Mar 5, 2024
12 of 14 checks passed

This was referenced Mar 6, 2024

[feature] Enable Setting Image Pull Policy in V2 SDK #9980

Closed

Add JosepSampe, revit13, and roytman to Kubeflow org kubeflow/internal-acls#663

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Backend + SDK): Update kfp backend and kubernetes sdk to support ImagePullPolicy #10417

feat(Backend + SDK): Update kfp backend and kubernetes sdk to support ImagePullPolicy #10417

revit13 commented Jan 21, 2024 •

edited

Loading

google-cla bot commented Jan 21, 2024

google-oss-prow bot commented Jan 21, 2024

Tomcli commented Jan 22, 2024

Tomcli commented Feb 7, 2024

Tomcli left a comment

zijianjoy commented Feb 8, 2024

Tomcli Feb 12, 2024 •

edited

Loading

revit13 Feb 25, 2024

Tomcli left a comment

Tomcli commented Feb 26, 2024

chensun commented Mar 5, 2024

revit13 commented Mar 5, 2024

chensun left a comment

chensun Mar 5, 2024

google-oss-prow bot commented Mar 5, 2024

google-oss-prow bot commented Mar 5, 2024

feat(Backend + SDK): Update kfp backend and kubernetes sdk to support ImagePullPolicy #10417

feat(Backend + SDK): Update kfp backend and kubernetes sdk to support ImagePullPolicy #10417

Conversation

revit13 commented Jan 21, 2024 • edited Loading

google-cla bot commented Jan 21, 2024

google-oss-prow bot commented Jan 21, 2024

Tomcli commented Jan 22, 2024

Tomcli commented Feb 7, 2024

Tomcli left a comment

Choose a reason for hiding this comment

zijianjoy commented Feb 8, 2024

Tomcli Feb 12, 2024 • edited Loading

Choose a reason for hiding this comment

revit13 Feb 25, 2024

Choose a reason for hiding this comment

Tomcli left a comment

Choose a reason for hiding this comment

Tomcli commented Feb 26, 2024

chensun commented Mar 5, 2024

revit13 commented Mar 5, 2024

chensun left a comment

Choose a reason for hiding this comment

chensun Mar 5, 2024

Choose a reason for hiding this comment

google-oss-prow bot commented Mar 5, 2024

google-oss-prow bot commented Mar 5, 2024

revit13 commented Jan 21, 2024 •

edited

Loading

Tomcli Feb 12, 2024 •

edited

Loading