Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Editing Pod's spec. #9714

Closed
stefanondisponibile opened this issue Jul 7, 2023 · 2 comments
Closed

[feature] Editing Pod's spec. #9714

stefanondisponibile opened this issue Jul 7, 2023 · 2 comments
Labels
area/sdk kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.

Comments

@stefanondisponibile
Copy link

stefanondisponibile commented Jul 7, 2023

Feature Area

/area sdk

What feature would you like to see?

I would like to understand what is the plan or the best practices for customizing the the Pod or container spec using kfp.
Is this feature going to be deprecated together with the rest of the v1 sdk?

What is the use case or pain point?

In my case, I'm trying to add some annotations (e.g. like it's defined here). The pain point is that I don't feel like using a deprecated feature.

Having some control over the final manifest is critical, especially in cases where you need sidecars, annotations, etc. The lack of this flexibility makes it difficult to deal with critical requirements such as secrets handling or cluster-specific customizations.

This in particular:

(PipelineTask) Replaces ContainerOp from kfp v1. Holds operations available on a task object, such as .after(), .set_memory_limit(), .enable_caching(), etc.

That etc is critical, we'll users be able to manipulate the final manifest? e.g. set_annotations?

Is there a workaround currently?

Not quite? Other than using deprecated APIs?

Related issues:


Love this idea? Give it a 👍.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Oct 5, 2023
Copy link

github-actions bot commented Jan 3, 2024

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.
Projects
Status: Closed
Development

No branches or pull requests

1 participant