Skip to content

Conversation

@yehudit1987
Copy link

@yehudit1987 yehudit1987 commented Nov 17, 2025

feat: Update Node toolchain to version 24 for kubeflow-common-lib ( #728 )

  • Update common_frontend_tests.yaml workflow to use Node 24
  • Add engines field to kubeflow-common-lib package.json to enforce Node >=24 <25 and npm >=10
  • Update all web app Dockerfiles (JWA, VWA, TWA) to use node:24-bookworm for building the common library
  • Update common README.md documentation to reflect Node 24 usage

The Dockerfiles needed updating because they build the kubeflow-common-lib,
and npm respects the engines field during 'npm ci', requiring Node 24.

feat: Upgrade Node.js to 24 for Jupyter Web App frontend (#729 )

  • Update jwa_frontend_tests.yaml workflow to use Node 24 in all three jobs (format/lint, unit tests, UI tests)
  • Add engines field to JWA frontend package.json to enforce Node >=24 <25 and npm >=10

feat: Upgrade Node.js to 24 for Tensorboards Web App frontend (#730 )

  • Update twa_frontend_tests.yaml workflow to use Node 24 in all three jobs (format/lint, unit tests, UI tests)
  • Add engines field to TWA frontend package.json to enforce Node >=24 <25 and npm >=10
  • Update tensorboards README.md documentation to reflect Node 24 requirement

feat: Upgrade Node.js to 24 for Volumes Web App frontend (#731 )

  • Update vwa_frontend_tests.yaml workflow to use Node 24 in all four jobs (format/lint, unit tests, chrome UI tests, firefox UI tests)
  • Add engines field to VWA frontend package.json to enforce Node >=24 <25 and npm >=10
  • Update Volumes README.md documentation to reflect Node 24 requirement

Validation

Local Build:

  • Built successfully with Node 24.11.1 and npm 11.6.2
  • All frontend tests passing

Integration Testing:

  • Deployed kind cluster with Kubeflow using deployment scripts from https://github.com/andyatmiami/kubeflow-scripts/tree/main
  • Deployed web apps with Node 24 changes from this repository
  • All web app services started successfully
  • UI accessible and functional
  • Successfully created and managed resources (notebooks, tensorboards, volumes) via web UI
  • No runtime errors or compatibility issues observed

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Nov 17, 2025
@google-oss-prow google-oss-prow bot added do-not-merge/work-in-progress area/backend area - related to backend components area/ci area - related to ci labels Nov 17, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the area/frontend area - related to frontend components label Nov 17, 2025
@google-oss-prow google-oss-prow bot added area/v1 area - version - kubeflow notebooks v1 size/XXL labels Nov 17, 2025
@yehudit1987 yehudit1987 force-pushed the feature/node-24-crud-webapps branch from e3d83ec to 4ae847c Compare November 19, 2025 08:50
@yehudit1987 yehudit1987 force-pushed the feature/node-24-crud-webapps branch from 4ae847c to 75da3d4 Compare November 19, 2025 09:00
@yehudit1987 yehudit1987 marked this pull request as ready for review November 19, 2025 09:40
@liavweiss
Copy link

Thank you, Yehudit
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/backend area - related to backend components area/ci area - related to ci area/frontend area - related to frontend components area/v1 area - version - kubeflow notebooks v1 lgtm size/XXL

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants