-
Notifications
You must be signed in to change notification settings - Fork 69
Open
Labels
area/v1area - version - kubeflow notebooks v1area - version - kubeflow notebooks v1kind/plan-taskkind - planning - taskkind - planning - task
Description
Certification
- I certify I am an Epic Owner for Kubeflow Notebooks 2.0 and expected to create planning-related issues.
Description
Update the Node toolchain for crud-web-apps/volumes/frontend to version 24.
Scope:
- Dockerfile: update both Node build stages
notebooks/components/crud-web-apps/volumes/DockerfileFROM node:24-bookworm as frontend-kubeflow-libFROM node:24-bookworm as frontend
- Ensure builds run under Node 24:
- Locally:
nvmuse 24 - CI: ensure builds run under Node 24
notebooks/.github/workflows/vwa_frontend_tests.yaml→ set node-version: 24 in all setup-node steps
- Locally:
- Optional: add engines to
package.jsonto enforce Node 24."engines": { "node": ">=24 <25", "npm": ">=10" }
- Validate:
cd notebooks/components/crud-web-apps/volumes/frontend && npm ci && npm run builddocker build -f notebooks/components/crud-web-apps/volumes/Dockerfile notebooks/components
Acceptance Criteria
- Volumes frontend builds successfully under Node 24 (CI green, Docker build ok).
Metadata
Metadata
Assignees
Labels
area/v1area - version - kubeflow notebooks v1area - version - kubeflow notebooks v1kind/plan-taskkind - planning - taskkind - planning - task
Type
Projects
Status
Needs Triage