Skip to content

Commit 75da3d4

Browse files
author
Yehudit Kerido
committed
feat: Update Node toolchain to version 24 for crud-web-apps
Signed-off-by: Yehudit Kerido <[email protected]>
1 parent 8c44fd7 commit 75da3d4

File tree

23 files changed

+10578
-56730
lines changed

23 files changed

+10578
-56730
lines changed

.github/workflows/common_frontend_tests.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
- name: Setup Node
2828
uses: actions/setup-node@v4
2929
with:
30-
node-version: 16
30+
node-version: 24
3131

3232
- name: Install dependencies
3333
run: npm ci
@@ -48,10 +48,10 @@ jobs:
4848
- name: Checkout
4949
uses: actions/checkout@v4
5050

51-
- name: Setup node version to 16
51+
- name: Setup node version to 24
5252
uses: actions/setup-node@v4
5353
with:
54-
node-version: 16
54+
node-version: 24
5555

5656
- name: Install Kubeflow common library dependencies
5757
run: npm ci

.github/workflows/jwa_frontend_tests.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: Setup Node
2323
uses: actions/setup-node@v4
2424
with:
25-
node-version: 16
25+
node-version: 24
2626
- name: Install dependencies
2727
run: npm ci
2828
- name: Check frontend formatting
@@ -37,10 +37,10 @@ jobs:
3737
- name: Checkout
3838
uses: actions/checkout@v4
3939

40-
- name: Setup node version to 16
40+
- name: Setup node version to 24
4141
uses: actions/setup-node@v4
4242
with:
43-
node-version: 16
43+
node-version: 24
4444

4545
- name: Install Kubeflow common library dependecies
4646
run: |
@@ -67,10 +67,10 @@ jobs:
6767
- name: Checkout
6868
uses: actions/checkout@v4
6969

70-
- name: Setup node version to 16
70+
- name: Setup node version to 24
7171
uses: actions/setup-node@v4
7272
with:
73-
node-version: 16
73+
node-version: 24
7474

7575
- name: Install Kubeflow common library dependecies
7676
run: |

.github/workflows/twa_frontend_tests.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
- name: Setup Node.js
2525
uses: actions/setup-node@v4
2626
with:
27-
node-version: 16
27+
node-version: 24
2828

2929
- name: Format tensorboards web app
3030
run: |
@@ -43,10 +43,10 @@ jobs:
4343
- name: Checkout code
4444
uses: actions/checkout@v4
4545

46-
- name: Setup node version to 16
46+
- name: Setup node version to 24
4747
uses: actions/setup-node@v4
4848
with:
49-
node-version: 16
49+
node-version: 24
5050

5151
- name: Install common library dependencies
5252
run: |
@@ -76,7 +76,7 @@ jobs:
7676
- name: Setup Node.js
7777
uses: actions/setup-node@v4
7878
with:
79-
node-version: 16
79+
node-version: 24
8080

8181
- name: Install common library dependencies
8282
run: |

.github/workflows/vwa_frontend_tests.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: Setup Node
2323
uses: actions/setup-node@v4
2424
with:
25-
node-version: 16
25+
node-version: 24
2626
- name: Install dependencies
2727
run: npm ci
2828
- name: Check frontend formatting
@@ -37,10 +37,10 @@ jobs:
3737
- name: Checkout
3838
uses: actions/checkout@v4
3939

40-
- name: Setup node version to 16
40+
- name: Setup node version to 24
4141
uses: actions/setup-node@v4
4242
with:
43-
node-version: 16
43+
node-version: 24
4444

4545
- name: Install Kubeflow common library dependecies
4646
run: |
@@ -64,10 +64,10 @@ jobs:
6464
- name: Checkout
6565
uses: actions/checkout@v4
6666

67-
- name: Setup node version to 16
67+
- name: Setup node version to 24
6868
uses: actions/setup-node@v4
6969
with:
70-
node-version: 16
70+
node-version: 24
7171

7272
- name: Install Kubeflow common library dependecies
7373
run: |
@@ -96,10 +96,10 @@ jobs:
9696
- name: Checkout
9797
uses: actions/checkout@v4
9898

99-
- name: Setup node version to 16
99+
- name: Setup node version to 24
100100
uses: actions/setup-node@v4
101101
with:
102-
node-version: 16
102+
node-version: 24
103103

104104
- name: Install Kubeflow common library dependecies
105105
run: |

components/crud-web-apps/common/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ You also need to add `"preserveSymlinks": true` to the app's frontend `angular.j
116116

117117
```dockerfile
118118
# --- Build the frontend kubeflow library ---
119-
FROM node:16 as frontend-kubeflow-lib
119+
FROM node:24 as frontend-kubeflow-lib
120120

121121
WORKDIR /src
122122

@@ -128,7 +128,7 @@ RUN npm run build
128128

129129
...
130130
# --- Build the frontend ---
131-
FROM node:16 as frontend
131+
FROM node:24 as frontend
132132
RUN npm install -g @angular/cli
133133

134134
WORKDIR /src

0 commit comments

Comments
 (0)