feat: workspace kind Edit Pod Configs #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaorell
changed the title
thaorell
force-pushed
the
notebooks-v2-workspace-kind-creation-podconfig
branch
from
1257622 to
d0bf720
Compare
thaorell
force-pushed
the
notebooks-v2-workspace-kind-creation-podconfig
branch
2 times, most recently
from
dfa1521 to
d9ee5da
Compare
thaorell
force-pushed
the
notebooks-v2-workspace-kind-creation-podconfig
branch
from
d9ee5da to
25ba155
Compare
caponetto
reviewed
Jun 25, 2025
workspaces/frontend/src/app/pages/WorkspaceKinds/Form/podConfig/ResourceInputWrapper.tsx
Show resolved
Hide resolved
thaorell
force-pushed
the
notebooks-v2-workspace-kind-creation-podconfig
branch
2 times, most recently
from
9dc4645 to
f73f632
Compare
thaorell
force-pushed
the
notebooks-v2-workspace-kind-creation-podconfig
branch
from
f73f632 to
d58cacc
Compare
caponetto
reviewed
Jun 27, 2025
workspaces/frontend/src/app/pages/WorkspaceKinds/Form/fileUpload/WorkspaceKindFileUpload.tsx
Outdated
Show resolved
Hide resolved
workspaces/frontend/src/app/pages/WorkspaceKinds/Form/podConfig/ResourceInputWrapper.tsx
Outdated
Show resolved
Hide resolved
workspaces/frontend/src/app/pages/WorkspaceKinds/Form/WorkspaceKindForm.tsx
Outdated
Show resolved
Hide resolved
workspaces/frontend/src/app/pages/WorkspaceKinds/Form/podConfig/WorkspaceKindFormPodConfig.tsx
Show resolved
Hide resolved
...ces/frontend/src/app/pages/WorkspaceKinds/Form/podConfig/WorkspaceKindFormPodConfigModal.tsx
Outdated
Show resolved
Hide resolved
.../frontend/src/app/pages/WorkspaceKinds/Form/podConfig/WorkspaceKindFormPodConfigResource.tsx
Outdated
Show resolved
Hide resolved
.../frontend/src/app/pages/WorkspaceKinds/Form/podConfig/WorkspaceKindFormPodConfigResource.tsx
Outdated
Show resolved
Hide resolved
.../frontend/src/app/pages/WorkspaceKinds/Form/podConfig/WorkspaceKindFormPodConfigResource.tsx
Outdated
Show resolved
Hide resolved
workspaces/frontend/src/app/pages/WorkspaceKinds/Form/podConfig/ResourceInputWrapper.tsx
Outdated
Show resolved
Hide resolved
workspaces/frontend/src/app/pages/WorkspaceKinds/Form/podConfig/ResourceInputWrapper.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Charles Thao <[email protected]>
Signed-off-by: Charles Thao <[email protected]>
Signed-off-by: Charles Thao <[email protected]>
Signed-off-by: Charles Thao <[email protected]>
thaorell
force-pushed
the
notebooks-v2-workspace-kind-creation-podconfig
branch
from
d58cacc to
a5dfec8
Compare
google-oss-prow
bot
added
area/frontend
thaorell
force-pushed
the
notebooks-v2-workspace-kind-creation-podconfig
branch
from
3c0dfff to
80d0937
Compare
Signed-off-by: Charles Thao <[email protected]>
thaorell
force-pushed
the
notebooks-v2-workspace-kind-creation-podconfig
branch
2 times, most recently
from
c5530bd to
6c5c5ff
Compare
thaorell
changed the title
thaorell
changed the title
caponetto
reviewed
Jul 1, 2025
workspaces/frontend/src/app/pages/WorkspaceKinds/Form/helpers.ts
Outdated
Show resolved
Hide resolved
workspaces/frontend/src/app/pages/WorkspaceKinds/Form/podConfig/WorkspaceKindFormResource.tsx
Show resolved
Hide resolved
...ces/frontend/src/app/pages/WorkspaceKinds/Form/podConfig/WorkspaceKindFormPodConfigModal.tsx
Outdated
Show resolved
Hide resolved
workspaces/frontend/src/app/pages/WorkspaceKinds/Form/podConfig/WorkspaceKindFormResource.tsx
Outdated
Show resolved
Hide resolved
thaorell
force-pushed
the
notebooks-v2-workspace-kind-creation-podconfig
branch
from
6c5c5ff to
1467f13
Compare
|
/ok-to-test |
thaorell
force-pushed
the
notebooks-v2-workspace-kind-creation-podconfig
branch
from
1467f13 to
596fb92
Compare
Signed-off-by: Charles Thao <[email protected]>
thaorell
force-pushed
the
notebooks-v2-workspace-kind-creation-podconfig
branch
from
596fb92 to
b5b1072
Compare
Screen.Recording.2025-07-02.at.4.42.40.PM.mov |
ederign
approved these changes
Jul 4, 2025
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
bhaktinarvekar
pushed a commit
to bhaktinarvekar/notebooks
that referenced
this pull request
Sep 14, 2025
* Add Pod Config to WorkspaceKind form Signed-off-by: Charles Thao <[email protected]> * Add resource section for PodConfig Signed-off-by: Charles Thao <[email protected]> * Use refactored types Signed-off-by: Charles Thao <[email protected]> * Improve Resource input Signed-off-by: Charles Thao <[email protected]> * Move form view to edit mode only Signed-off-by: Charles Thao <[email protected]> * Bug fix and improvements Signed-off-by: Charles Thao <[email protected]> --------- Signed-off-by: Charles Thao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #356
related: #365