Skip to content

Conversation

@thaorell
Copy link

@thaorell thaorell commented Jul 3, 2025

closes: #354
depends on: #425

  1. Add 'Edit' action to WorkspaceKind table and populate form with WS kind's data from api
  2. Add advanced settings for pods in Workspace Kind Edit:
  • Pod Metadata: Allow users to add labels (used for identifying, selecting, and grouping resources) and annotations (for arbitrary, non-identifying metadata)
  • Culling: Add 'time' type to ResourceInputWrapper and allow admin to cull inactive pods
  • Extra volume mounts
  1. Enable WorkspaceKindForm to detect 409 errors from API

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Jul 3, 2025
@google-oss-prow google-oss-prow bot added area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 size/XXL labels Jul 3, 2025
@thaorell thaorell force-pushed the notebooks-v2-workspace-kind-creation-podtemplate branch 2 times, most recently from 8b8d83a to 5b8b1b0 Compare July 7, 2025 19:45
@google-oss-prow google-oss-prow bot added size/XL and removed size/XXL labels Jul 7, 2025
@paulovmr
Copy link

paulovmr commented Jul 8, 2025

/ok-to-test

@thaorell thaorell force-pushed the notebooks-v2-workspace-kind-creation-podtemplate branch 3 times, most recently from 0723c5c to dc94422 Compare July 10, 2025 13:46
@thaorell thaorell force-pushed the notebooks-v2-workspace-kind-creation-podtemplate branch from dc94422 to 6119465 Compare July 10, 2025 15:10
@thaorell thaorell requested a review from paulovmr July 10, 2025 15:24
Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 10, 2025
@thaorell
Copy link
Author

Screen.Recording.2025-07-10.at.11.32.13.AM.mov

Copy link
Member

@ederign ederign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit fb0e74a into kubeflow:notebooks-v2 Jul 10, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Jul 10, 2025
noalimoy pushed a commit to noalimoy/notebooks that referenced this pull request Jul 17, 2025
bhaktinarvekar pushed a commit to bhaktinarvekar/notebooks that referenced this pull request Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/XL

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants