StudyJob v1alpha2 API version

[johnugeorge]

There are couple of changes that are suggested. We can incorporate all these changes in the next API version.

• Consistent field naming unify studyjob json tag #351 , unify name style of api/studyjob field whose type is array in v1alpha2 API version #371
• Extending Status fields to contain all conditions Katib job status should contain all conditions, not just the latest one #344
• Extending Status fields to have detailed info Katib status should return optimal parameters values #356 Getting optimal parameters after a study is complete #122
• Renaming RequestNumber, RequestCount the question about the requestNumber #161
• Custom TemplateSpec for workers/metrics support worker/metricsCollector template from specified configmap + path #349
• StudyName field is unnecessary StudyName field is unnecessary #380

Please add if I missed out any.

/cc @richardsliu @YujiOshima @hougangliu

---

Implementation (last updated 5/13/2019):

• Controllers implementation [v1alpha2] Controller implementation #441
• Metrics collection [v1alpha2] Metrics collection #442
• New UI [v1alpha2] New UI #443
• Suggestion algorithms implementation Move all suggestion algorithms to python #407
• DB operations DB operations for v1alpha2 #510
• Support custom resources Support for Custom Job resources #512
• Update kustomize packages Create kustomize packages for v1alpha2 version #513
• Add e2e tests Add e2e tests for v1alpha2 #514
• implement UpdateTrialStatusObservation #551

[hougangliu]

@johnugeorge please also add #349

[hougangliu]

BTW, now we have some API/filed whose type is array, some of them are named with plural type and some are named with List-suffix (such as below). I think we should name them with same style in v1alpha2 API.

rpc GetStudyList(GetStudyListRequest) returns (GetStudyListReply)
rpc GetTrials(GetTrialsRequest) returns (GetTrialsReply)

type StudyJobStatus struct {
...
Trials []TrialSet json:"trials,omitempty"
...
}
type TrialSet struct {
TrialID string json:"trialid,omitempty"
WorkerList []WorkerCondition json:"workeridlist,omitempty"
}

[johnugeorge]

@hougangliu can you create an issue ?

[hougangliu]

@johnugeorge Done #371

[johnugeorge]

It would be better if all other current bigger PRs are reviewed and merged before moving to v1alpha2. Else, PRs need be modified for newer version too.

PRs which should be reviewed and merged:

@YujiOshima #362 #352
@DeeperMind #339 #345
@Akado2009 #328

[richardsliu]

How about #346 ? It might require some API changes too.

#341 is not API related but would require controller side changes, and would be good to add as well.

[YujiOshima]

#291 is also a big change for the logic of controller.
It would be good to add.

[johnugeorge]

@YujiOshima @richardsliu i was listing out issues that need API changes. Except #346(not finalized yet), other mentioned issues are already tagged with 0.5.0 which can be tracked separately. Other than issues included in #370 (comment), we will get all new controller changes in v1alpha2.

[YujiOshima]

@johnugeorge OK, Thanks.

It would be better if all other current bigger PRs are reviewed and merged before moving to v1alpha2. Else, PRs need be modified for newer version too.

Every PRs that include changes of DB scheme are blocked by #359 .
First of all, we should fix this. See #360

[jlewi]

Now that #381 is merged what is the remaining work here?

[richardsliu]

I think we should keep this issue open until the implementation is done. In any case this should be moved to 0.6.

[gaocegege]

Hi, all

Could we do the jobs parallel? It seems that the process is blocked by #435

BTW I am free these days and can work on some items.

[richardsliu]

There are a few PRs in flight:

• Python migration #435
• v1alpha2 api server implementation #456
• Adding initial v1alpha2 API controller #457
• WIP: New UI #438

I think after #457 is merged we can split up the remainder of the work.

[jlewi]

@richardsliu @johnugeorge @gaocegege Any update on this issue?

[hougangliu]

@jlewi we're still working on UI #438 and suggestion services #435 (maybe a new PR will replace it to take over), plan to make them done by the end of this week.

[jlewi]

What are the remaining changes to be code complete for v1alpha2?
Is someone working on porting over the suggestion algorithms to the new API?

[johnugeorge]

@jlewi Yes. I have started on it

[richardsliu]

This should be done now.
/close

[k8s-ci-robot]

@richardsliu: Closing this issue.

In response to this:

This should be done now.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.