Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1alpha2] Controller implementation #441

Closed
richardsliu opened this issue Mar 27, 2019 · 10 comments · Fixed by #457
Closed

[v1alpha2] Controller implementation #441

richardsliu opened this issue Mar 27, 2019 · 10 comments · Fixed by #457
Assignees
@johnugeorge
Labels
area/0.6.0

Comments

@richardsliu
Copy link
Contributor

No description provided.

@johnugeorge johnugeorge mentioned this issue Mar 27, 2019
Closed
15 tasks
@gaocegege
Copy link
Member

@johnugeorge Are you working on this issue?

@johnugeorge
Copy link
Member

Yes. I will add the initial implementation once #448 is merged.

@johnugeorge
Copy link
Member

/assign

@richardsliu
Copy link
Contributor Author

@johnugeorge Can we break this item up into smaller issues? So community members can work on this together.

@gaocegege
Copy link
Member

Agree. Or could you please open a WIP PR then we can review it earlier.

@johnugeorge
Copy link
Member

Sure. I was waiting for #435 to get merged as GetSuggestions needs to be implemented first. Also, few GRPC apis also need to be implemented and @YujiOshima is working on it.
I will anyways raise my current changes in 1-2 days.

@richardsliu
Copy link
Contributor Author

@YujiOshima Do you have a PR for the gRPC changes?

@YujiOshima
Copy link
Contributor

I'm working on it. I will open PR this week.

@jlewi
Copy link
Contributor

jlewi commented Apr 22, 2019

@richardsliu @johnugeorge @YujiOshima How's this coming?

@johnugeorge johnugeorge mentioned this issue Apr 22, 2019
Merged
@johnugeorge
Copy link
Member

@jlewi #457 is in the final review. It should be merged in 1-2 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnugeorge johnugeorge

Labels
area/0.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding initial v1alpha2 API controller johnugeorge/katib
5 participants
@jlewi @johnugeorge @gaocegege @YujiOshima @richardsliu