feat: create generic git client interface#1418
Merged
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
9 tasks
tnevrlka
force-pushed
the
refactor-git-clients
branch
from
c4cc3ed to
cd380d7
Compare
tnevrlka
force-pushed
the
refactor-git-clients
branch
from
cd380d7 to
d841258
Compare
9 tasks
mmorhun
approved these changes
Oct 15, 2024
mmorhun
reviewed
Oct 15, 2024
tnevrlka
force-pushed
the
refactor-git-clients
branch
from
d841258 to
71d43ff
Compare
- The common controller currently contains Github and Gitlab clients - Their functions differ - Make the clients implement a provider-agnostic Git client interface so that provider-agnostic functions can be used in tests
tnevrlka
force-pushed
the
refactor-git-clients
branch
from
71d43ff to
8afa6a8
Compare
Member
|
/lgtm |
flacatus
approved these changes
Oct 16, 2024
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flacatus, mmorhun, tisutisu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tnevrlka
added a commit
to tnevrlka/e2e-tests
that referenced
this pull request
Oct 17, 2024
- The common controller currently contains Github and Gitlab clients - Their functions differ - Make the clients implement a provider-agnostic Git client interface so that provider-agnostic functions can be used in tests # Conflicts: # pkg/clients/common/controller.go # pkg/clients/git/git.go # pkg/clients/git/github.go # pkg/clients/git/gitlab.go # pkg/utils/build/git.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue ticket number and link
STONEBLD-2389
Type of change
How Has This Been Tested?
This change is not being tested in this particular revision. I've used the functionality created in this pull request in build tests, please see the following PRs: #1419, #1421
Checklist: