refactor: use generic client in gitlab build tests#1421
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
9 tasks
tkdchen
reviewed
Oct 10, 2024
tkdchen
left a comment
tkdchen
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Left a few comments.
mmorhun
reviewed
Oct 15, 2024
tnevrlka
force-pushed
the
refactor-gitlab-build-tests
branch
from
938970b to
ed331dc
Compare
tnevrlka
force-pushed
the
refactor-gitlab-build-tests
branch
3 times, most recently
from
a41e73e to
0540f8a
Compare
mmorhun
approved these changes
Oct 17, 2024
tnevrlka
force-pushed
the
refactor-gitlab-build-tests
branch
2 times, most recently
from
57e23b6 to
0e3bb66
Compare
tisutisu
reviewed
Oct 18, 2024
tnevrlka
force-pushed
the
refactor-gitlab-build-tests
branch
from
0e3bb66 to
ca40b84
Compare
Contributor
Author
|
/retest |
tnevrlka
force-pushed
the
refactor-gitlab-build-tests
branch
from
ca40b84 to
063ae99
Compare
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
- Use generic, provider-agnostic, Git client functions leading to a nicer, more readable and maintainable code
tnevrlka
force-pushed
the
refactor-gitlab-build-tests
branch
from
063ae99 to
5ba26c5
Compare
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmorhun, tisutisu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is currently not possible to merge a PR with multiple commits without squashing them. Created #1418 that should be merged before this, so we can avoid squashing
Description
Use generic, provider-agnostic, Git client functions leading to a nicer, more readable and maintainable code
Issue ticket number and link
N/A
Type of change
How Has This Been Tested?
./bin/e2e-appstudio --ginkgo.v --ginkgo.label-filter=build-serviceChecklist: