feat: add tests for nudging gitlab repos#1419
Conversation
|
Skipping CI for Draft Pull Request. |
tnevrlka
force-pushed
the
gitlab-nudging-tests
branch
2 times, most recently
from
5b17f07 to
08476b1
Compare
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
| "github.com/konflux-ci/e2e-tests/pkg/clients/git" |
There was a problem hiding this comment.
Please separate standard and other dependencies
| ChildComponentDef.gitRepo = fmt.Sprintf(githubUrlFormat, githubOrg, ChildComponentDef.repoName) | ||
| ParentComponentDef.componentName = fmt.Sprintf("multi-component-parent-%s", branchString) | ||
| ChildComponentDef.componentName = fmt.Sprintf("multi-component-child-%s", branchString) | ||
| switch gitProvider { |
There was a problem hiding this comment.
This should be at least a separate function, imo
| // get the build pipeline bundle annotation | ||
| buildPipelineAnnotation = build.GetDockerBuildPipelineBundle() | ||
|
|
||
| if gitProvider == "gitlab" { |
There was a problem hiding this comment.
We can have github with token too
tnevrlka
force-pushed
the
gitlab-nudging-tests
branch
from
dae1d45 to
698726d
Compare
- Nudging functionality is currently only being tested for GitHub repositories - Switch to Git provider-agnostic functions and test GitLab repositories too
tnevrlka
force-pushed
the
gitlab-nudging-tests
branch
from
698726d to
18caa46
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tisutisu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
It is currently not possible to merge a PR with multiple commits without squashing them. Created #1418 that should be merged before this, so we can avoid squashing
Description
being tested for GitHub repositories
and test GitLab repositories too
Issue ticket number and link
STONEBLD-2389
Type of change
How Has This Been Tested?
Added
Focusto the changed tests and ran e2e-tests.Checklist: