Use library.sh from prow-tests image, instead of yet another copy of it#1639
Merged
google-prow-robot merged 3 commits intoknative:masterfrom Jul 22, 2018
adrcunha:bye-library-sh
Merged
Use library.sh from prow-tests image, instead of yet another copy of it#1639google-prow-robot merged 3 commits intoknative:masterfrom adrcunha:bye-library-sh
google-prow-robot merged 3 commits intoknative:masterfrom
adrcunha:bye-library-sh
Conversation
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `library.sh` in prow-tests image was implemented by knative/test-infra#4
google-prow-robot
added
the
size/L
Contributor
Author
|
/hold This must be merged after #1622 otherwise |
google-prow-robot
added
the
do-not-merge/hold
Contributor
Author
|
/hold cancel |
google-prow-robot
removed
the
do-not-merge/hold
Contributor
|
/lgtm |
Contributor
|
/approve |
1 similar comment
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, jessiezcc, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
bbrowning
pushed a commit
to bbrowning/serving
that referenced
this pull request
Oct 5, 2018
…it (knative#1639) * Use library.sh from prow-tests image, instead of yet another copy of it We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `library.sh` in prow-tests image was implemented by knative/test-infra#4 * Use start_latest_knative_serving() instead of manually installing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.
library.shin prow-tests image was implemented by knative/test-infra#4