Remove local library.sh as all helpers are now in prow-tests image#258
Remove local library.sh as all helpers are now in prow-tests image#258google-prow-robot merged 3 commits intoknative:masterfrom adrcunha:no-library-sh-in-hack
Conversation
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `library.sh` in prow-tests image was implemented by knative/test-infra#4
google-prow-robot
added
the
size/L
adrcunha
requested review from
jessiezcc and
srinivashegde86
and removed request for
inlined and
steuhs
|
/lgtm |
|
/test pull-knative-eventing-integration-tests |
|
/test pull-knative-eventing-unit-tests |
|
/test pull-knative-eventing-build-tests |
| # Useful environment variables | ||
| [[ -n "${PROW_JOB_ID}" ]] && IS_PROW=1 || IS_PROW=0 | ||
| readonly IS_PROW | ||
| readonly EVENTING_ROOT_DIR="$(dirname $(readlink -f ${BASH_SOURCE}))/.." |
There was a problem hiding this comment.
this is EVENTING specific which doesn't exist in common library.sh, tests fail due to this.
"./hack/verify-codegen.sh: line 22: EVENTING_ROOT_DIR: unbound variable
W0721 15:26:07.837] mkdir: cannot create directory '': No such file or directory"
There was a problem hiding this comment.
Argh! There was actually a bug: wrong variable name. Fixed, thanks.
|
/lgtm |
adrcunha
requested review from
mattmoor and
vaikas
and removed request for
srinivashegde86
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
4 participants
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.
library.shin prow-tests image was implemented by knative/test-infra#4