-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin knative/pkg and knative/test-infra to release-0.17 #976
Conversation
@@ -28,7 +28,7 @@ VERSION="master" | |||
# The list of dependencies that we track at HEAD and periodically | |||
# float forward in this repository. | |||
FLOATING_DEPS=( | |||
"knative.dev/pkg@${VERSION}" | |||
"knative.dev/pkg@release-0.17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that line 50 will need a similar change, or the mix of variable vs. constant should be juggled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Harwayne, maximilien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* Pin pkg to release-0.17 branch. * hack/update-deps.sh --upgrade * Update hack/update-deps.sh for the test-infra section. * hack/update-deps.sh --upgrade
* Allow overriding of build.sh for downstream projects (knative#1544) * Adding override script for kn-plugin-event (knative#910) * Embed event plugin (knative#905)
Proposed Changes
release-0.17
.release-0.17
of knative/client in a week.Release Note