Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin knative/pkg and knative/test-infra to release-0.17 #976

Merged
merged 4 commits into from
Aug 11, 2020

Conversation

Harwayne
Copy link
Contributor

Proposed Changes

  • Pin knative/pkg to release-0.17.
    • In preparation for release-0.17 of knative/client in a week.

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 11, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 11, 2020
@@ -28,7 +28,7 @@ VERSION="master"
# The list of dependencies that we track at HEAD and periodically
# float forward in this repository.
FLOATING_DEPS=(
"knative.dev/pkg@${VERSION}"
"knative.dev/pkg@release-0.17"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that line 50 will need a similar change, or the mix of variable vs. constant should be juggled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@knative-prow-robot knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 11, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2020
@mattmoor
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@knative-prow-robot knative-prow-robot merged commit eda276b into knative:master Aug 11, 2020
@Harwayne Harwayne deleted the pin-pkg-17 branch August 11, 2020 19:24
@navidshaikh navidshaikh added this to the v0.17.0 milestone Aug 12, 2020
@navidshaikh navidshaikh changed the title Pin knative/pkg to release-0.17 Pin knative/pkg and knative/test-infra to release-0.17 Aug 12, 2020
rhuss pushed a commit to rhuss/knative-client that referenced this pull request Sep 9, 2020
* Pin pkg to release-0.17 branch.

* hack/update-deps.sh --upgrade

* Update hack/update-deps.sh for the test-infra section.

* hack/update-deps.sh --upgrade
dsimansk pushed a commit to dsimansk/client that referenced this pull request Feb 23, 2022
* Allow overriding of build.sh for downstream projects (knative#1544)

* Adding override script for kn-plugin-event (knative#910)

* Embed event plugin (knative#905)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants