Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add broker management feature to changelog #905

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

dsimansk
Copy link
Contributor

Sorry I forgot to add changelog update in my previous PR.

@rhuss
@navidshaikh

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 23, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2020
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 23, 2020
@knative-prow-robot knative-prow-robot merged commit a7f18cb into knative:master Jun 23, 2020
@dsimansk dsimansk deleted the broker-crud-changelog branch June 24, 2020 04:35
dsimansk pushed a commit to dsimansk/client that referenced this pull request Dec 10, 2021
* Allow overriding of build.sh for downstream projects

* Embed kn-plugin-event

* Adding override script for kn-plugin-event
dsimansk pushed a commit to dsimansk/client that referenced this pull request Feb 23, 2022
* Allow overriding of build.sh for downstream projects (knative#1544)

* Adding override script for kn-plugin-event (knative#910)

* Embed event plugin (knative#905)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants