Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Allow overriding of build.sh for downstream projects #1544

Merged

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Dec 9, 2021

Changes

  • 🎁 Allow overriding of build.sh for downstream projects
  • ✨ Clean the scripts a bit, especially with SC2155 issue

Reference

Fixes #1543

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #1544 (c0e8280) into main (404cda5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1544   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files         162      162           
  Lines        8553     8553           
=======================================
  Hits         6805     6805           
  Misses       1071     1071           
  Partials      677      677           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 404cda5...c0e8280. Read the comment docs.

@cardil cardil marked this pull request as draft December 9, 2021 16:35
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2021
@cardil cardil force-pushed the feature/allow-overriding-build branch from 04cadb8 to c0e8280 Compare December 9, 2021 20:36
@cardil
Copy link
Contributor Author

cardil commented Dec 9, 2021

/test all

@cardil cardil marked this pull request as ready for review December 9, 2021 21:50
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2021
@cardil
Copy link
Contributor Author

cardil commented Dec 9, 2021

/cc @rhuss
/cc @dsimansk
/cc @vyasgun

@cardil
Copy link
Contributor Author

cardil commented Dec 9, 2021

Flaky?

/test pull-knative-client-integration-tests-latest-release

@dsimansk
Copy link
Contributor

Thanks!

/approve
/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2021
@knative-prow-robot knative-prow-robot merged commit e7d7cad into knative:main Dec 10, 2021
@cardil cardil deleted the feature/allow-overriding-build branch December 10, 2021 14:58
cardil added a commit to cardil/knative-client that referenced this pull request Feb 23, 2022
openshift-merge-robot pushed a commit to openshift/knative-client that referenced this pull request Feb 23, 2022
* Allow overriding of build.sh for downstream projects (knative#1544)

* Adding override script for kn-plugin-event (#910)

* Embed event plugin (#905)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to override hack/build.sh script functionality for forks
3 participants