Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings for the popover attribute #229

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

garrappachc
Copy link

@garrappachc garrappachc commented Jun 6, 2024

Adds typings for the popover attribute, according to the spec.

Closes #228

Copy link

changeset-bot bot commented Jun 6, 2024

🦋 Changeset detected

Latest commit: 6f19263

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kitajs/html Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@arthurfiorette
Copy link
Member

thanks!

@arthurfiorette arthurfiorette enabled auto-merge (squash) June 6, 2024 14:53
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (8ea9d05) to head (6f19263).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files           5        5           
  Lines         456      456           
=======================================
  Hits          454      454           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurfiorette arthurfiorette merged commit e575ef8 into kitajs:master Jun 6, 2024
8 checks passed
@arthurfiorette arthurfiorette mentioned this pull request Jun 6, 2024
@garrappachc garrappachc deleted the add-popover-attr branch June 7, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the popover attribute
2 participants