Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the popover attribute #228

Closed
2 tasks done
garrappachc opened this issue Jun 6, 2024 · 2 comments · Fixed by #229
Closed
2 tasks done

Support the popover attribute #228

garrappachc opened this issue Jun 6, 2024 · 2 comments · Fixed by #229

Comments

@garrappachc
Copy link

garrappachc commented Jun 6, 2024

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Versions

4.1.0

Description

When I want to use the popover attribute, e.g.:

<div popover id="my-popover">Greetings, one and all!</div>

I get the following error:

error TS2322: Type '{ children: Element[]; popover: true; class: string; }' is not assignable to type 'HtmlTag'.
  Property 'popover' does not exist on type 'HtmlTag'.

Steps to Reproduce

Use the popover attribute in a HTML tag.

Expected Behavior

The popover attribute is typed as 'auto' | 'manual'.

@arthurfiorette
Copy link
Member

Hey @garrappachc, nice feature request, are you up to PR it?

@garrappachc
Copy link
Author

Hey @garrappachc, nice feature request, are you up to PR it?

Sure! I'll tackle this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants