Handle self closing elements ts-html-plugin #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…necessary errors, impr debug expiriance
🦋 Changeset detectedLatest commit: f17d190 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
arthurfiorette
previously approved these changes
Mar 25, 2024
Signed-off-by: Arthur Fiorette <[email protected]>
arthurfiorette
added
fastify-plugin
arthurfiorette
previously approved these changes
Mar 25, 2024
|
why is CI not running??? |
Signed-off-by: Arthur Fiorette <[email protected]>
Merged
|
Released at |
|
Just confirming that this fixed my issue (#149). Thank you very much @JacopoPatroclo & @arthurfiorette! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #149
closes #146
This PR aims to resolve the above issues
I've noticed that a self-closing element must be validated as a JSX element before they were not. Furthermore, I've changed the
recursiveDiagnoseJsxElementsimplementation to handle the fact that a self-closing element expression does not have children. I've added a couple of expressions in the tests to show such cases.@arthurfiorette let me know if this makes sense or if I should add more test cases.