Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly incorrect detection for conditional elements #146

Closed
2 tasks done
alexgorbatchev opened this issue Jan 23, 2024 · 2 comments · Fixed by #158
Closed
2 tasks done

Possibly incorrect detection for conditional elements #146

alexgorbatchev opened this issue Jan 23, 2024 · 2 comments · Fixed by #158
Assignees
Labels
bug Something isn't working ts-plugin Related to @kitajs/ts-html-plugin

Comments

@alexgorbatchev
Copy link

alexgorbatchev commented Jan 23, 2024

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Saw kitajs/ts-html-plugin#24, feels like this is still a problem

Versions

1.3.3

Description

No errors:

<Icon icon={icon} size={size} />

K601

{!hideIcon && <Icon icon={icon} size={size} />}

Steps to Reproduce

example above

Expected Behavior

Should have no errors

{!hideIcon && <Icon icon={icon} size={size} />}
@kravetsone
Copy link

I have the same problem!
image

{user.avatar ? (
						<img safe src={STATIC_URL + `/${user.avatar}`} alt="avatar" />
					) : (
						<div
							style={`background-color: hsl(${generateHueFromSource(
								domain,
							)}, 70%, 40%); width:100px; height:100px;`}
						>
							a
						</div>
					)}

@arthurfiorette
Copy link
Member

Thanks for creating this issue, anyone up to a PR?

@arthurfiorette arthurfiorette transferred this issue from kitajs/ts-html-plugin Mar 11, 2024
@arthurfiorette arthurfiorette self-assigned this Mar 11, 2024
@arthurfiorette arthurfiorette added the ts-plugin Related to @kitajs/ts-html-plugin label Mar 11, 2024
@arthurfiorette arthurfiorette moved this to 📋 Backlog in Kita development Mar 11, 2024
@arthurfiorette arthurfiorette added the bug Something isn't working label Mar 11, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Kita development Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ts-plugin Related to @kitajs/ts-html-plugin
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants