KIALI-2456,2459,2466,2465, 2450 and 2507 . Improve toolbar for Jaeger Integration and refactor by aljesusg · Pull Request #1025 · kiali/kiali-ui

aljesusg · 2019-02-26T09:45:20Z

KIALI-2456 Error Traces shows kiali home when refreshing the page
KIALI-2459 Fix traces tab if value is -1
KIALI-2466 Remove visual options in jaeger toolbar (Hide graph, hide summary) and make the search button bigger
KIALI-2465 Get Services in jaegerToolbar is not working after Openshift oauth changes
KIALI-2450 Change the namespace Selector in Jaeger Distributed tracing view to be like other views
KIALI-2507 Distributed tracing link disappear in a new tab
KIALI-2515 UI About - Components not persist when the user open a new tab
All removed from redux to improve performance
Now when you click lookback custom by default is set the dates from 1 hour
Now we support query params in the jaeger integration

josejulio · 2019-02-26T16:16:02Z

  key: persistKey,
  storage: storage,
-  whitelist: ['authentication', 'namespaces', 'serverConfig'],
+  whitelist: ['authentication', 'namespaces', 'serverConfig', 'jaegerState'],


Should we store all the jaegerState? I'm worried about storing information that might not be accurate the next time we use Kiali such as: toolbar.isFetchingService and jaegerURL.

Please, if needed, consider to only store a subset of this, see: https://github.com/kiali/kiali-ui/blob/master/src/store/ConfigStore.ts#L30-L41

Totally agree , I am still testing why the state of redux take time in get updated before the rendering of the component, We'll only persist the jaegerUrl.

aljesusg · 2019-02-27T08:28:28Z

@hhovsepy I fixed the problem here, now traces tab is hide until load. But I see another problems like the missing sidecar icon (See the gif)

Maybe we should create some loading view while we fetch the backend what do you think @lucasponce @jotak @xeviknal ?

aljesusg · 2019-02-27T08:50:58Z

Removed visual options (Enable by default) to avoid the user get confuse and make the search button more visual. What do you think @pilhuhn ? I think that this is clearer now

pilhuhn · 2019-02-27T09:18:01Z

@aljesusg Much better. I personally (but I don't speak for UxD) would even put the search button next to the input boxes and not "far away" in the corner.

aljesusg · 2019-02-28T12:37:52Z

  whitelist: ['authentication', 'namespaces', 'serverConfig'],
-  transforms: [namespacePersistFilter]
+  transforms: [namespacePersistFilter, ...persitingJaegerReducers]
 };


Now I persist only the data required @josejulio

hhovsepy · 2019-02-28T12:48:19Z

Tested all the issues mentioned in the description.
Only problem is when kiali is in https and jeager-query is with http, the Traces tab is hidden.

aljesusg · 2019-02-28T12:49:55Z

Fixed !!! Thanks !!!

aljesusg · 2019-03-01T10:29:42Z

I keep the same namespace selector, and now you can see all services of the namespace selected like in jaeger view.

jotak · 2019-03-01T10:37:13Z

Waw that's a title! :-) Maybe you could set a more meaningful title to better identify this PR in our notifications?

aljesusg · 2019-03-01T10:40:29Z

Waw that's a title! :-) Maybe you could set a more meaningful title to better identify this PR in our notifications?

So Jiras in the same PR ^^ I'll change to another title with more sense, In the description you can see the JIRAs related. Sorry @jotak ^^

hhovsepy · 2019-03-01T12:31:02Z

Verified all issues mentioned:
Toolbar, services, search button, namespaces, and redirecting when http.

lucasponce · 2019-03-01T15:28:20Z

One thing I see, that can be addressed in a different PR, is that traces tab is not linkable.
Parameters are not added into the url.

lucasponce · 2019-03-01T15:31:17Z

Sometimes the search button doesn't honor the parameters:

Same query:

That is confusing.

lucasponce

Commented with @aljesusg that there is a pending bug
#1025 (comment)
that probably is good to fix on this PR.

Other comments probably can be in separate tasks.

aljesusg · 2019-03-11T10:46:30Z

Pr rdy for review @lucasponce @xeviknal @hhovsepy

hhovsepy · 2019-03-11T11:48:32Z

Login page is not opened, it shows empty page, on both browsers.

aljesusg · 2019-03-11T11:58:16Z

Login page is not opened, it shows empty page, on both browsers.

!!! What ??? No console output ? I didn't change nothing from login ^^ I am building the UI to check this

aljesusg · 2019-03-11T12:06:20Z

Ok I found the problem, I had persistStore and I didn't see that. Thanks @hhovsepy

aljesusg · 2019-03-11T12:20:20Z

Fixed @hhovsepy and I did the JIRA https://issues.jboss.org/browse/KIALI-2515 too, it was related with the status too.

Thanks !!!

hhovsepy · 2019-03-11T13:07:39Z

Tested all the issues mentioned in the description.
Only problem is when kiali is in https and jeager-query is with http, the Traces tab is not redirecting.

hhovsepy · 2019-03-11T13:07:57Z

hhovsepy · 2019-03-11T13:57:26Z

All verified now.

KIALI-2459 Fix traces tab if value is -1 KIALI-2466 Remove visual options in jaeger toolbar (Hide graph, hide summary) and make the search button bigger KIALI-2465 Get Services in jaegerToolbar is not working after Openshift oauth changes KIALI-2450 Change the namespace Selector in Jaeger Distributed tracing view to be like other views KIALI-2507 Distributed tracing link disappear in a new tab KIALI-2515 UI About - Components not persist when the user open a new tab

lucasponce · 2019-03-12T10:00:27Z

Not a blocker for this PR, but I think we need to document on this Sprint all the steps/troubleshooting related with certificates, like this case:

Known issues, or something that is not really a Kiali issue but we can point users when they ask for it.

lucasponce

Testing locally and tested both with https + http to validate that links are external and https + https, where after accepting the certificate, everything seems to work as expected.

aljesusg force-pushed the k_2456 branch from 1fdf653 to dea2ab4 Compare February 26, 2019 09:53

aljesusg changed the title ~~WIP KIALI-2456 KIALI-2459~~ KIALI-2456 KIALI-2459 Feb 26, 2019

aljesusg force-pushed the k_2456 branch from dc8a976 to 7b47222 Compare February 26, 2019 12:27

josejulio mentioned this pull request Feb 26, 2019

KIALI-2437 Show "n/a" when there is an error reading the error tr… #1017

Closed

josejulio reviewed Feb 26, 2019

View reviewed changes

aljesusg mentioned this pull request Feb 27, 2019

KIALI-1906 Support for security and non security environments #1008

Merged

aljesusg force-pushed the k_2456 branch 2 times, most recently from f1df8f2 to 798d333 Compare February 27, 2019 09:11

aljesusg force-pushed the k_2456 branch from 798d333 to 53880c2 Compare February 27, 2019 09:32

aljesusg added the do not merge A PR is not ready to merge label Feb 27, 2019

aljesusg commented Feb 28, 2019

View reviewed changes

aljesusg force-pushed the k_2456 branch from a3969d1 to e8175b2 Compare February 28, 2019 12:48

aljesusg force-pushed the k_2456 branch 2 times, most recently from 8205c41 to 2053cd4 Compare February 28, 2019 16:31

aljesusg changed the title ~~KIALI-2456 KIALI-2459~~ KIALI-2456 KIALI-2459 KIALI-2466 KIALI-2465 KIALI-2450 Feb 28, 2019

aljesusg force-pushed the k_2456 branch from 2053cd4 to 4bc64bb Compare March 1, 2019 10:27

aljesusg removed the do not merge A PR is not ready to merge label Mar 1, 2019

aljesusg requested review from hhovsepy, jotak, lucasponce and xeviknal March 1, 2019 10:30

aljesusg changed the title ~~KIALI-2456 KIALI-2459 KIALI-2466 KIALI-2465 KIALI-2450~~ KIALI-2456,2459,2466,2465 and 2450 . Fix Bugs, improve toolbar for Jaeger Integration and refactor Mar 1, 2019

hhovsepy approved these changes Mar 1, 2019

View reviewed changes

lucasponce suggested changes Mar 4, 2019

View reviewed changes

aljesusg force-pushed the k_2456 branch from fc868ba to 553273d Compare March 11, 2019 08:31

aljesusg changed the title ~~KIALI-2456,2459,2466,2465 and 2450 . Fix Bugs, improve toolbar for Jaeger Integration and refactor~~ KIALI-2456,2459,2466,2465, 2450 and 2507 . Improve toolbar for Jaeger Integration and refactor Mar 11, 2019

aljesusg force-pushed the k_2456 branch from 553273d to 3a03690 Compare March 11, 2019 10:45

aljesusg force-pushed the k_2456 branch 2 times, most recently from 59d111f to 21909a9 Compare March 11, 2019 11:25

aljesusg force-pushed the k_2456 branch 2 times, most recently from 22a3368 to f745ffe Compare March 11, 2019 12:19

aljesusg force-pushed the k_2456 branch 2 times, most recently from d17eb8d to 2871fd6 Compare March 11, 2019 13:56

aljesusg force-pushed the k_2456 branch from 2871fd6 to 7aed0ad Compare March 12, 2019 09:18

Rebased after merge kiali#1043

8e3d03b

aljesusg force-pushed the k_2456 branch from 7aed0ad to 8e3d03b Compare March 12, 2019 09:32

lucasponce approved these changes Mar 12, 2019

View reviewed changes

lucasponce merged commit 79edc7f into kiali:master Mar 12, 2019

aljesusg deleted the k_2456 branch September 9, 2019 08:36

Conversation

aljesusg commented Feb 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

josejulio Feb 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aljesusg Feb 27, 2019

Choose a reason for hiding this comment

Uh oh!

aljesusg commented Feb 27, 2019

Uh oh!

aljesusg commented Feb 27, 2019

Uh oh!

pilhuhn commented Feb 27, 2019

Uh oh!

aljesusg Feb 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hhovsepy commented Feb 28, 2019

Uh oh!

aljesusg commented Feb 28, 2019

Uh oh!

aljesusg commented Mar 1, 2019

Uh oh!

jotak commented Mar 1, 2019

Uh oh!

aljesusg commented Mar 1, 2019

Uh oh!

hhovsepy commented Mar 1, 2019

Uh oh!

lucasponce commented Mar 1, 2019

Uh oh!

lucasponce commented Mar 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucasponce left a comment

Choose a reason for hiding this comment

Uh oh!

aljesusg commented Mar 11, 2019

Uh oh!

hhovsepy commented Mar 11, 2019

Uh oh!

aljesusg commented Mar 11, 2019

Uh oh!

aljesusg commented Mar 11, 2019

Uh oh!

aljesusg commented Mar 11, 2019

Uh oh!

hhovsepy commented Mar 11, 2019

Uh oh!

hhovsepy commented Mar 11, 2019

Uh oh!

hhovsepy commented Mar 11, 2019

Uh oh!

lucasponce commented Mar 12, 2019

Uh oh!

lucasponce left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aljesusg commented Feb 26, 2019 •

edited

Loading

josejulio Feb 26, 2019 •

edited

Loading

aljesusg Feb 28, 2019 •

edited

Loading

lucasponce commented Mar 1, 2019 •

edited

Loading