KIALI-1906 Support for security and non security environments#1008
KIALI-1906 Support for security and non security environments#1008aljesusg merged 9 commits intokiali:masterfrom
Conversation
|
Sounds fair. |
|
Hey @jotak I did the changes requested in the jaeger integration PR, can you review it? |
src/config/paths.ts
Outdated
| * Paths | ||
| */ | ||
|
|
||
| export enum paths { |
There was a problem hiding this comment.
Oops, wrong one, enums are PascalCase ;-)
https://github.com/basarat/typescript-book/blob/master/docs/styleguide/styleguide.md#enum
I think this file was good as it was before, also regarding its name (Path.ts) and the enum values (for which we decided to keep upper case)
| status: Status; | ||
| items: string[]; | ||
| targetPage: Paths; | ||
| targetPage: string; |
There was a problem hiding this comment.
Why remove Paths? It's more specific typing, so better.
|
@aljesusg there's just a missing comment from the previous PR, not addressed yet: https://github.com/kiali/kiali-ui/pull/965/files#r258911600 : we don't use |
Changed Thanks |
aljesusg
force-pushed
the
support_cases_jaeger
branch
from
f98acab to
708629e
Compare
|
So I tested these scenarios:
So I think this is what's expected. |
|
Done @jotak My concern is about the link of Distributed Tracing Link that opens jaeger in a new tab too |
|
@aljesusg yes there's the same problem with the distributed tracing link. But at least, it doesn't affect the nominal case where both jaeger and kiali are under https. I would say it's good enough. |
|
When refreshing the Service Details page, it first appears "Traces" tab with external link, then within an 1/2 sec, switches to "Error Traces" tab. |
|
This is by the redux state I think let me check it @hhovsepy |
|
@hhovsepy I'll fix this problems in #1025 see comment #1025 (comment) Thanks |
4 participants
With this we support the integration of Jaeger with Iframe when:
When one of them is with security and the other without we'll have the link to the jaeger website.
What do you think @lucasponce, @jotak ?
With this we only need to work in the JAEGER_URL provided by the backend or Makefile