This repository was archived by the owner on Apr 11, 2023. It is now read-only.
KIALI-2437 Show "n/a" when there is an error reading the error tr…#1017
Closed
josejulio wants to merge 2 commits intokiali:masterfrom
Closed
KIALI-2437 Show "n/a" when there is an error reading the error tr…#1017josejulio wants to merge 2 commits intokiali:masterfrom
josejulio wants to merge 2 commits intokiali:masterfrom
Conversation
Contributor
Contributor
|
Yes, unknown is not much better than -1. What about "n/a" ? Would need UX input. |
josejulio
changed the title
Contributor
Author
Contributor
|
No, Please this was something that I forget to change. When the value is -1 the traces should show the normal traces of the services because that means that there is a problem getting traces of jaeger |
aljesusg
reviewed
Feb 26, 2019
| <span>n/a</span> | ||
| </OverlayTrigger> | ||
| )} | ||
| {errorTraces > 0 && ( |
Contributor
There was a problem hiding this comment.
Hi @josejulio , I was working in another PR to fix this that I forgot. when the value is -1 the Error traces tab should be a tab with name "Traces" ans show all the traces of this service. -1 means that there is a problem getting traces in Jaeger this could mean a timeout. When there is not JaegerURL configured the traces tab is hide.
Contributor
Author
|
Fixed with #1025 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ace count
** Describe the change **
Shows
n/ainstead of-1in the UI when there was an error reading the "error trace" count.I'm not sure if we want to give more context about the error or if is fine as is for now.
** Screenshot **