Skip to content
This repository was archived by the owner on Apr 11, 2023. It is now read-only.

KIALI-2437 Show "n/a" when there is an error reading the error tr… #1017

Closed
josejulio wants to merge 2 commits into from
Closed

KIALI-2437 Show "n/a" when there is an error reading the error tr… #1017

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
256da31
KIALI-2437 Show "Unknown" when there is an error reading the error tr…
josejulio Feb 22, 2019
3f582eb
KIALI-2437 Replace Unknown with n/a
josejulio Feb 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/pages/ServiceDetails/ServiceDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react';
import { RouteComponentProps } from 'react-router-dom';
import { Nav, NavItem, TabContainer, TabContent, TabPane, Icon } from 'patternfly-react';
import { Nav, NavItem, TabContainer, TabContent, TabPane, Icon, OverlayTrigger, Tooltip } from 'patternfly-react';
import ServiceId from '../../types/ServiceId';
import * as API from '../../services/Api';
import * as MessageCenter from '../../utils/MessageCenter';
Expand Down Expand Up @@ -177,7 +177,23 @@ class ServiceDetails extends React.Component<ServiceDetailsProps, ServiceDetails
<div>
Error Traces{' '}
<span>
({errorTraces}
(
{errorTraces !== -1 ? (
errorTraces
) : (
<OverlayTrigger
overlay={
<Tooltip id="error-trace-unknown-tooltip">
There was a problem loading the <b>Error Trace</b> count from the server
</Tooltip>
}
placement="top"
trigger={['hover', 'focus']}
rootClose={false}
>
<span>n/a</span>
</OverlayTrigger>
)}
{errorTraces > 0 && (
Copy link
Copy Markdown
Contributor

@aljesusg aljesusg Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @josejulio , I was working in another PR to fix this that I forgot. when the value is -1 the Error traces tab should be a tab with name "Traces" ans show all the traces of this service. -1 means that there is a problem getting traces in Jaeger this could mean a timeout. When there is not JaegerURL configured the traces tab is hide.

<Icon type={'fa'} name={'exclamation-circle'} style={{ color: 'red', marginLeft: '2px' }} />
)}
Expand Down