Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the AdminUI supports only email/pass auth strategy? #2480

Closed
chomamateusz opened this issue Mar 4, 2020 · 5 comments
Closed

Why the AdminUI supports only email/pass auth strategy? #2480

chomamateusz opened this issue Mar 4, 2020 · 5 comments

Comments

@chomamateusz
Copy link

I've added 2 auth strategies: Google and FB, with redirects URL /auth/google and /auth/fb.

Next I've forked the AdminUI, and I've added 2 regular buttons with href to URLs mentioned above.

FBandGoogleLogin

Why this is not allowed by new AdminUIApp constructor? Only thing that UI needs in OAuth auth is the redirect URL for each method (and maybe button props) and it could simply generate this buttons for me.

I've not battle tested it yet, but for now as I'm testing Keystone possibilities, it works like a charm - I can log is through FB and Google.

Is that more complicated than I think? Or simply no one implemented it yet?

@jesstelford
Copy link
Contributor

Why this is not allowed by new AdminUIApp constructor?

We literally just haven't gotten to it yet 😉

Would love to see a PR with some of these enhancements.

One thing to consider is; not every app will want every authentication method. And there may be apps which use a non-core authentication method (for example; I have a custom library which does a hacky passwordless thing that's WIP right now, maybe I want to be able to plug that straight into the Admin UI too).

@stale
Copy link

stale bot commented Jul 2, 2020

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

@stale stale bot added the needs-review label Jul 2, 2020
@dimaip
Copy link

dimaip commented Mar 19, 2021

Does anyone know if this is still the issue for Keystone-next or if its admin supports more auth methods now?

@stale stale bot removed the needs-review label Mar 19, 2021
@stale
Copy link

stale bot commented Jul 17, 2021

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

@dcousens
Copy link
Member

Please see our discussions on this topic, https://github.com/keystonejs/keystone/discussions?discussions_q=is%3Aopen+authentication and for specific feature requests

@dcousens dcousens closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants