Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access control API docs #4922

Merged
merged 9 commits into from
Feb 25, 2021
Merged

Access control API docs #4922

merged 9 commits into from
Feb 25, 2021

Conversation

timleslie
Copy link
Contributor

@timleslie timleslie commented Feb 22, 2021

@vercel
Copy link

vercel bot commented Feb 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/8kb1ojWRQmoUqspnUFkZNyCca95g
✅ Preview: https://keystone-next-docs-git-access-control-api-keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2021

⚠️ No Changeset found

Latest commit: 7c30119

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview February 23, 2021 00:59 Inactive
@vercel vercel bot temporarily deployed to Preview February 23, 2021 02:30 Inactive
@vercel vercel bot temporarily deployed to Preview February 23, 2021 03:16 Inactive
@vercel vercel bot temporarily deployed to Preview February 23, 2021 03:26 Inactive
@vercel vercel bot temporarily deployed to Preview February 23, 2021 05:02 Inactive
@vercel vercel bot temporarily deployed to Preview February 23, 2021 05:52 Inactive
@vercel vercel bot temporarily deployed to Preview February 23, 2021 05:56 Inactive
@gautamsi
Copy link
Member

@timleslie I wanted to remind you of condition in #3239 which was fixed in #3241, there was one condition left that it may still have incorrect sequence if user has no access to update some items (based on declarative control like isLocked = true) then the sequence in the resolveInput and afterChange would be different in the array.

I can explain more if it does not remind you full context.

@vercel vercel bot temporarily deployed to Preview February 24, 2021 01:50 Inactive
@timleslie
Copy link
Contributor Author

@timleslie I wanted to remind you of condition in #3239 which was fixed in #3241, there was one condition left that it may still have incorrect sequence if user has no access to update some items (based on declarative control like isLocked = true) then the sequence in the resolveInput and afterChange would be different in the array.

I can explain more if it does not remind you full context.

Thanks for the reminder of these. I'm going to follow this up with a separate PR to fix that behaviour.

@vercel vercel bot temporarily deployed to Preview February 24, 2021 03:25 Inactive
@vercel vercel bot temporarily deployed to Preview February 24, 2021 03:35 Inactive
@vercel vercel bot temporarily deployed to Preview February 24, 2021 21:10 Inactive
@timleslie timleslie changed the title [WIP] Access control API docs Access control API docs Feb 24, 2021
docs-next/pages/apis/access-control.mdx Outdated Show resolved Hide resolved
docs-next/pages/apis/access-control.mdx Outdated Show resolved Hide resolved
docs-next/pages/apis/access-control.mdx Outdated Show resolved Hide resolved
docs-next/pages/apis/access-control.mdx Outdated Show resolved Hide resolved
docs-next/pages/apis/access-control.mdx Outdated Show resolved Hide resolved
docs-next/pages/apis/access-control.mdx Outdated Show resolved Hide resolved
docs-next/pages/apis/access-control.mdx Outdated Show resolved Hide resolved
docs-next/pages/apis/access-control.mdx Outdated Show resolved Hide resolved
docs-next/pages/apis/access-control.mdx Outdated Show resolved Hide resolved
docs-next/pages/apis/access-control.mdx Outdated Show resolved Hide resolved
Co-authored-by: Jed Watson <[email protected]>
@vercel vercel bot temporarily deployed to Preview February 24, 2021 23:55 Inactive
Co-authored-by: Jed Watson <[email protected]>
@vercel vercel bot temporarily deployed to Preview February 24, 2021 23:58 Inactive
@timleslie timleslie requested a review from JedWatson February 25, 2021 00:00
@vercel vercel bot temporarily deployed to Preview February 25, 2021 00:03 Inactive
@vercel vercel bot temporarily deployed to Preview February 25, 2021 00:11 Inactive
Copy link
Member

@JedWatson JedWatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@vercel vercel bot temporarily deployed to Preview February 25, 2021 00:23 Inactive
@timleslie timleslie enabled auto-merge (squash) February 25, 2021 00:23
@timleslie timleslie disabled auto-merge February 25, 2021 00:26
@vercel vercel bot temporarily deployed to Preview February 25, 2021 00:30 Inactive
@timleslie timleslie enabled auto-merge (squash) February 25, 2021 00:30
@timleslie timleslie disabled auto-merge February 25, 2021 00:35
@vercel vercel bot temporarily deployed to Preview February 25, 2021 00:36 Inactive
@timleslie timleslie enabled auto-merge (squash) February 25, 2021 00:36
@timleslie timleslie merged commit b1da780 into master Feb 25, 2021
@timleslie timleslie deleted the access-control-api branch February 25, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants