Remove itemId from FieldAccessArgs

[timleslie]

Found this gap while documenting the access-control API in #4922

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/DFyu4jZodWsb5HthnidwoWnj4Q2c
✅ Preview: https://keystone-next-docs-git-field-access-read-item-id-keystonejs.vercel.app

[emmatown]

What's the rationale behind this if they already receive the item?

[timleslie]

What's the rationale behind this if they already receive the item?

Very good question 🤔 it ostensibly makes the arguments for FieldAccessArgs match those for ListAccessArgs.

On reflection, there are slight differences in the semantics of itemId in each of these cases, which might lead to confusion. I think you're right, we'd be better off completely removing the itemId from FieldAccessArgs.

Once the API docs PR has landed I'll change this PR to remove itemId and make sure the docs come along for the ride 👍

[emmatown]

Do you know if there is a FieldAccessArgs or something in @keystone-next/types that would also have itemId on it?

[timleslie]

Do you know if there is a FieldAccessArgs or something in @keystone-next/types that would also have itemId on it?

So... there are, but they're already a little bit broken and somewhat tricky to work with. I have another branch in the works which brings all this stuff up to date with reality, so I'll make sure that this change is reflected in there when it lands.