Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate call to fetchStaticAdminMeta #4885

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Conversation

JedWatson
Copy link
Member

This corrects an error in #4879 and actually fixes #4828

The right fix was added, but the previous code wasn't removed so the infinite loop was still happening.

Sorry about this -- you actually have to clear your localStorage to reproduce this error so it took us longer to properly fix than it should have. We'll be adding some cypress tests shortly to catch things like this sooner.

@vercel
Copy link

vercel bot commented Feb 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/jz7vhkc6g
✅ Preview: https://keystone-next-docs-git-fix-4828-infinite-loop.keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2021

🦋 Changeset detected

Latest commit: 6695bba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview February 18, 2021 13:35 Inactive
@JedWatson JedWatson merged commit 9a9276e into master Feb 18, 2021
@JedWatson JedWatson deleted the fix-4828-infinite-loop branch February 18, 2021 13:40
@vercel vercel bot temporarily deployed to Preview February 18, 2021 13:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydration Error on Admin UI
1 participant