Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin meta fetching #4879

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Fix admin meta fetching #4879

merged 1 commit into from
Feb 18, 2021

Conversation

emmatown
Copy link
Member

Close #4828

I'm not really sure when this broke or why it broke, my best guess is the react 17 bump or the bump to @apollo/client in #4512. (it was hard to catch because it only happens when the admin meta hasn't been cached)

@vercel
Copy link

vercel bot commented Feb 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/9583tfhm2
✅ Preview: https://keystone-next-docs-git-fix-admin-meta-fetching.keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2021

🦋 Changeset detected

Latest commit: bbf71e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emmatown emmatown enabled auto-merge (squash) February 18, 2021 06:24
Copy link
Contributor

@gwyneplaine gwyneplaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emmatown emmatown merged commit 0e265f6 into master Feb 18, 2021
@emmatown emmatown deleted the fix-admin-meta-fetching branch February 18, 2021 06:26
@gautamsi
Copy link
Member

I don't see this working, still having same issue

@MurzNN
Copy link
Contributor

MurzNN commented Feb 18, 2021

Pull from latest master with this PR merged didn't resolve the issue for me too.

@JedWatson
Copy link
Member

Yep me too, sorry about that -- fixed fix incoming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydration Error on Admin UI
5 participants