respects cloudinary secure setting in admin
#4118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same as keystonejs#2427, extending the fix to the builtin uploader.
|
I would love to see this merged. I'm on 4.0.0-beta.5, and cloudinary images in the admin are loading over http, even with |
|
It ( |
|
Gonna pick this up again shortly since it looks like tests are working now |
|
@r1b Any word on this? It would be nice to have this merged. |
|
Closing this in favor of #4175. The other PR also addresses every location cloudinary uses images or generates urls. |
|
Thank you, Noviny! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #2427, extending the fix to the builtin uploader.
Description of changes
Ensures cloudinary images are rendered with https on the admin when
cloudinary secureis set.Related issues (if any)
#2427
Testing
npm run test-allran successfully.I ran
npm testsuccessfully - when I tried to run the e2e tests they would hang on Starting Selenium server....