Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wysiwyg cloudinary image upload https #2427

Closed
steveellis opened this issue Mar 15, 2016 · 2 comments
Closed

wysiwyg cloudinary image upload https #2427

steveellis opened this issue Mar 15, 2016 · 2 comments
Labels

Comments

@steveellis
Copy link

Wondering if there is a configuration option for making the inserted image source be https when inserting a cloudinary image using the wysiwyg option (enabled by the 'wysiwyg cloudinary images': true option) for the html data type .

I've tried doing

keystone.set('cloudinary secure', true);

but the inserted url is still http.

Would be super duper great to have this because otherwise would have to train users to view source and add https to every image they upload--something easily forgotten. :)

@mxstbr
Copy link
Collaborator

mxstbr commented Mar 15, 2016

That is a good catch, that should probably happen when cloudinary secure is true.

@mxstbr mxstbr added bug and removed question labels Mar 15, 2016
@steveellis
Copy link
Author

Thanks for confirming and for marking it as a bug.

suryagh added a commit to suryagh/keystone that referenced this issue Mar 19, 2016
Fixed keystonejs#2427. The `cloudinary uploader` does return both the `secure` and `non-secure` urls to the uploaded image. Modified the code to return `secure` url to the client if `cloudinary secure` option is set to `true`
JedWatson added a commit that referenced this issue Mar 19, 2016
Fixed issue #2427 - wysiwyg cloudinary image upload https
r1b added a commit to r1b/keystone that referenced this issue Mar 17, 2017
This is the same as keystonejs#2427, extending the fix to the builtin uploader.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants