Shortcut Icons and IDs

[githubsterer]

Developer TODO (don't remove)

• update documentation

Describe the bug
Testing the fix for the shortcut icons and seeing strange things unless it is intended.

First, I uninstalled the older version. This automatically deleted all the home shortcuts, which I can understand, but then when you restore from the backup it should create the same shortcuts again, rather than having to do it again manually.

Of the two shortcut icon issues I raised, the new version no longer creates blank icons but instead uses the symbol from the action, which is somewhat confusing, rather than what it normally creates, which is just the standard app icon. Not sure that was what you intended, but if so, would still really like an option to revert to the standard icon. What confuses me is that is only happening with some of my key maps but not others from the restore.

Second, and also strange, the issue about not being able to save the shortcut with any name unless there's no action chosen, seems somewhat fixed in that some of my actions allow it and others do not but interestingly, this is linked to the issue above in that the key maps that produce the strange icons are like before where the name option is not even present, but the key maps that create normal icons do allow naming even with actions stored. Something is amiss.

I don't see anything yet that allows you to actually rename an icon but I assume the workaround is to just save a new one, however, that feature as described above isn't fully working yet and I also want to make sure that when you do, that it replaces the previous shortcut rather than having multiple ones for the same key map.

Also, the Discard Changes dialog is still confusing to me because it always prompts even when no changes are made, but maybe you're not tracking changes and just throw it up each time? If so, the wording that you have unsaved changes when you really don't, is very confusing.

[githubsterer]

I mean, frankly, this is just a silly name for a shortcut, right? I mean, maybe some people like it, but it's forcing that name and you can't rename it in the finder so you're kind of stuck units you create the icon before the actions are loaded, but you don't have that choice after a restore.

[githubsterer]

My Catch 22 is that it takes too much effort to re-program the key maps every time I upgrade the app on order to get the shortcuts with normal names and icons, which is what I have to do until it's fixed.

[githubsterer]

Can confirm that saved shortcuts do not replace but duplicate, but this may be normal behavior in Android as I can see some benefit in being able to populate multiple home pages with the same command though having more than one shortcut perform the same task is strange from a UI perspective..

[jambl3r]

Please could you try to keep issues targeted at 1 bug or 1 feature at a time, it's quite difficult to manage conversation-style threads. Each issue should be actionable and only relate to one thing. When there are multiple things going on, it becomes hard to measure if the problem is solved.

If one part is fixed and other part is not fixable, should the issue stay open, close as not planned, close as completed? ... you can imagine it can be confusing and the last thing we want to happen is for a great suggestion or critical bug being forgotten.

Also, issue titles should be immediately understandable so we can see at a glance what work is outstanding.

I will open sub-issues for the unique concerns you raised.

[jambl3r]

Also, the Discard Changes dialog is still confusing to me because it always prompts even when no changes are made, but maybe you're not tracking changes and just throw it up each time? If so, the wording that you have unsaved changes when you really don't, is very confusing.

Already covered by #1427

[githubsterer]

My apologies, I'm new to this bug reporting process and will do better in the future, just trying to help. I assume I've said enough about what the issues are and will stand down unless you need more info from me. Sorry again.

[jambl3r]

No worries, I've created #1472 , #1473 and #1474 so please follow those if you would like further updates or to add more information.

[githubsterer]

Thanks, so much better organized now.  On Sun, Feb 23, 2025 at 6:46 AM, Jack ***@***.***> wrote: No worries, I've created #1472 , #1473 and #1474 so please follow those if you would like further updates or to add more information. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***> jambl3r left a comment (keymapperorg/KeyMapper#1470) No worries, I've created #1472 , #1473 and #1474 so please follow those if you would like further updates or to add more information. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>