Option to choose app shortcut icon

[jambl3r]

Developer TODO (don't remove)

• update documentation

Of the two shortcut icon issues I raised, the new version no longer creates blank icons but instead uses the symbol from the action, which is somewhat confusing, rather than what it normally creates, which is just the standard app icon. Not sure that was what you intended, but if so, would still really like an option to revert to the standard icon. What confuses me is that is only happening with some of my key maps but not others from the restore.

[githubsterer]

This presumes what I see in the latest rev is intended (icons from the actions) because even then it is not consistent, where some of my icons use the action image while others use the standard app icon. If you intended the former, then likely it's not fully implementing.

Truth is, I'm kind of getting used to it now whereas it was jarring at first, but ultimately it would best to have the choice between the two when saving.

[jambl3r]

App shortcuts do inherit from the actions and that's intended, and sometimes actions don't have an icon so it uses the key mapper icon instead. If you have multiple actions it also used the key mapper icon.

In some launchers you can set the icon yourself, but it is a reasonable suggestion that key mapper could handle that for you.

[jambl3r]

Are there any cases where you are expecting an icon but you get the default logo?

[githubsterer]

So you've explained why I'm probably getting a mix of both icon types and the reason I never saw this earlier is because the icons were blank. But yes, having a choice is nice and I guess you should make sure every action has an icon for consistency.

[githubsterer]

I suppose that in cases with multiple actions the suggested icon should be from the first action in the list.

[jambl3r]

I suppose that in cases with multiple actions the suggested icon should be from the first action in the list.

This is probably too big of an assumption. Better to just let the user control the icon.

[githubsterer]

Agreed.