Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always provide option to name key map shortcut #1474

Open
1 task
jambl3r opened this issue Feb 23, 2025 · 2 comments
Open
1 task

Always provide option to name key map shortcut #1474

jambl3r opened this issue Feb 23, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request needs triage

Comments

@jambl3r
Copy link
Collaborator

jambl3r commented Feb 23, 2025

Developer TODO (don't remove)

  • update documentation

Second, and also strange, the issue about not being able to save the shortcut with any name unless there's no action chosen, seems somewhat fixed in that some of my actions allow it and others do not but interestingly, this is linked to the issue above in that the key maps that produce the strange icons are like before where the name option is not even present, but the key maps that create normal icons do allow naming even with actions stored. Something is amiss.

I don't see anything yet that allows you to actually rename an icon but I assume the workaround is to just save a new one, however, that feature as described above isn't fully working yet and I also want to make sure that when you do, that it replaces the previous shortcut rather than having multiple ones for the same key map.

@jambl3r jambl3r added enhancement New feature or request needs triage labels Feb 23, 2025
@jambl3r jambl3r mentioned this issue Feb 23, 2025
1 task
@githubsterer
Copy link

To be clear, it isn't so much a new option that's needed because this feature already exists when you create the shortcut prior to adding any actions. What I'm looking for is just carrying over that same idea in all cases, where the creation of any shortcut always prompts for a name. If you think there's still some benefit for the shortcut to be named after the action, then it could be prefilled in the dialog, but done already highlighted so that the new name can easily be typed over it.

@jambl3r jambl3r changed the title Option to give app shortcut custom name Always provide option to name app shortcut Feb 23, 2025
@jambl3r
Copy link
Collaborator Author

jambl3r commented Feb 23, 2025

Good point, yeah I think the action name should be a suggestion but not forced.

@sds100 sds100 changed the title Always provide option to name app shortcut Always provide option to name key map shortcut Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
Development

No branches or pull requests

3 participants