Repository navigation
fix(sentry): filter injected ethereum/__firefox__ browser noise - #1164
Conversation
Drop wallet shim and Firefox-iOS bridge globals (window.ethereum, window.__firefox__) that throw from page global code on Brave iOS — not from Kody bundles (issues 7648833360, 7648833403). Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe Sentry browser filters now identify known wallet and Firefox bridge errors from exceptions and event messages. Browser events and buffered client errors matching these patterns are discarded. Tests cover matching and unrelated errors. ChangesBrowser Sentry noise filtering
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔎 Preview deployed: https://kody-pr-1164.kody-a99.workers.dev Worker: Mocks:
|
Summary
Sentry issue 7648833360 (
window.ethereum.selectedAddress) and siblings 7648833403 / 7648833423 (__firefox__) are Brave iOS pageglobal codethrows from wallet / Firefox-bridge injected globals — not Kody bundles.Adds a narrow client
beforeSendfilter (and matching pre-SDK buffer ignore) for those exact message shapes.Outcome: filtered — squash-merged; competing #1165/#1166 stood down as subsets.
System recap — composes existing primitives (low risk)
Mode: recap · Base:
main@802e658a· Head:6585f652(merged as0f7d759)Classification: composes — extends the existing browser Sentry filter wiring in
app-uionly; no new primitives or contracts.Primitives touched
app-uibeforeSend/ buffer drop for injected-global noiseSystem map
Browser Sentry init already runs
filterBrowserSentryEvent; this PR adds one more drop predicate for wallet/__firefox__injection messages.Legend: green = composes (wiring only) · amber = extended by this PR · red = new primitive · gray = context (unchanged, included only when an edge crosses it).
Summary by CodeRabbit
Bug Fixes
Tests