Repository navigation
fix(sentry): filter Firefox __firefox__ bridge noise (KODY-CLOUDFLARE-3F) - #1165
Closed
kentcdodds wants to merge 1 commit into
Closed
kentcdodds wants to merge 1 commit into
kentcdodds wants to merge 1 commit into
Conversation
…Send Browser-injected Firefox reader/content-bridge scripts throw ReferenceError and TypeError when window.__firefox__ is absent. Drop those signatures in the client beforeSend (and pre-init buffer) so KODY-CLOUDFLARE-3F / 3E stop alerting; app source never references __firefox__. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cursor
Bot
deleted the
cursor/sentry-triage-kody-cloudflare-kody-cloudflare-3f-056c
branch
August 4, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Superseded — do not merge. Stand down in favor of #1164.
Three triage agents spawned for the same Brave/iOS injected-global Sentry cluster and opened competing PRs that all touch
sentry-browser-filters.ts. Merging more than one will conflict.Decision
Keep #1164 (earliest; covers both
window.ethereum.*and__firefox__signatures for issues 7648833360 + 7648833403).Also overlapping: #1166 (KODY-CLOUDFLARE-3G,
__firefox__only) — should close as duplicate of #1164 as well.This PR (#1165) only filters
__firefox__and is a strict subset of #1164.Original summary (historical)
ReferenceError: Can't find variable: __firefox__onheykody.dev//pricing,global codeonly, no app frames.__firefox__references — browser/injected bridge noise.Testing
npm test -- packages/worker/client/sentry-browser-filters.node.test.ts