Repository navigation
fix(sentry): drop injected og:type meta probe noise (KODY-CLOUDFLARE-46) - #1316
Merged
kody-bot merged 1 commit intoAug 8, 2026
Merged
Conversation
Filter Mobile Safari / content-script TypeErrors that unguardedly read
document.querySelector("meta[property='og:type']").content from global
code on the document URL (KODY-CLOUDFLARE-46). Kody never reads og:type
this way; match requires the Safari evaluating wording and a global code
frame.
kentcdodds
marked this pull request as ready for review
August 8, 2026 14:11
📝 WalkthroughWalkthroughThe browser Sentry filters now detect Safari ChangesOG-type Sentry filtering
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
🔎 Preview deployed: https://kody-pr-1316.kody-a99.workers.dev Worker: Mocks:
|
kody-bot
deleted the
cursor/sentry-triage-kody-cloudflare-kody-cloudflare-46-1e01
branch
August 8, 2026 14:17
kody-bot
pushed a commit
that referenced
this pull request
Aug 8, 2026
* fix(sentry): drop injected og:type meta probe noise
Filter Mobile Safari / content-script TypeErrors that unguardedly read
document.querySelector("meta[property='og:type']").content from global
code on the document URL (KODY-CLOUDFLARE-46). Kody never reads og:type
this way; match requires the Safari evaluating wording and a global code
frame.
* chore: re-trigger main validate after flaky E2E
Post-merge Validate on #1316 failed with Playwright ECONNREFUSED to the
local webserver (infra flake; PR CI and pre-push E2E were green). Empty
commit to re-run push Validate so production deploy can proceed.
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
kody-bot
pushed a commit
that referenced
this pull request
Aug 8, 2026
* fix(sentry): drop injected og:type meta probe noise
Filter Mobile Safari / content-script TypeErrors that unguardedly read
document.querySelector("meta[property='og:type']").content from global
code on the document URL (KODY-CLOUDFLARE-46). Kody never reads og:type
this way; match requires the Safari evaluating wording and a global code
frame.
* chore: re-trigger main validate after flaky E2E
Post-merge Validate on #1316 failed with Playwright ECONNREFUSED to the
local webserver (infra flake; PR CI and pre-push E2E were green). Empty
commit to re-run push Validate so production deploy can proceed.
* test(e2e): fail fast when wrangler dies and upload its logs
When the Playwright webServer exits mid-suite, remaining tests were burning
CI retries on ECONNREFUSED. Probe /health before each test, abort auth retries
immediately on connection refused, and upload logs.local/ from the E2E job on
failure so the next empty [WebServer] ERROR is diagnosable.
* test(e2e): cap auth request timeouts to remaining retry budget
Address CodeRabbit feedback: each /auth attempt now uses the leftover
retry budget as its Playwright request timeout so the default 30s API
timeout cannot overrun the 15s login retry window.
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filters a one-off Mobile Safari client noise event from KODY-CLOUDFLARE-46: injected
global codeunguardedly readingdocument.querySelector("meta[property='og:type']").contenton/guides/what-is-kody.Root cause
global codeframe on the document URL (not a Kody bundle).og:typein document-head / SSR; it never reads it viaquerySelector.CONFIG, wallet/__firefox__globals, etc.).Fix
Narrow client
beforeSendfilter insentry-browser-filters.ts:null is not an object (evaluating 'document.querySelector(…og:type…).content')global codeUnit coverage in
sentry-browser-filters.node.test.ts.Status
e93230b8; production redeployed via #1317 after a flaky post-merge E2EECONNREFUSEDon main blocked the first deploy.01b3c1ad.Risk
Low / composes — observability filter only; no product behavior change.
System recap — composes existing primitives (low risk)
Mode: recap · Base:
main@12efe549· Head:e5b8fda9Classification: composes — extends the existing browser Sentry noise filter chain only; no primitive contracts change.
Primitives touched
app-uibeforeSenddrop for injected og:type probesSystem map
Browser Sentry still boots from the client entry; this PR only adds one more drop predicate before envelopes leave the page.
Legend: green = composes (wiring only) · amber = extended by this PR · red = new primitive · gray = context (unchanged, included only when an edge crosses it).
Change flow
Summary by CodeRabbit
Bug Fixes
og:typemetadata probes.Documentation
og:typeprobes and related cases.