Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mid-stream app signing support to release-tool #2101

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

droidmonkey
Copy link
Member

Description

Just in time for v2.3.4! Doing some house cleaning on the release tool to automate things I was doing by hand. Also took this moment to align the "key" parameters between the different modes, they all use -k|--key now.

  • Add automatic portable zip building
  • Cleanup build variables
  • Align command line parameters between modes

Motivation and context

Doing things by hand is bad, mmkay

How has this been tested?

Manually building 2.3.4

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • ✅ My change requires a change to the documentation and I have updated it accordingly.

* Add automatic portable zip building
* Cleanup build variables
* Align command line parameters between modes
@droidmonkey droidmonkey added this to the v2.3.4 milestone Jul 9, 2018
@droidmonkey droidmonkey requested a review from phoerious July 9, 2018 02:38
@droidmonkey droidmonkey merged commit 4b51b39 into release/2.3.4 Jul 9, 2018
@TheZ3ro TheZ3ro deleted the fix/release-tool branch July 12, 2018 15:26
droidmonkey added a commit that referenced this pull request Aug 22, 2018
- Show all URL schemes in entry view [#1768]
- Disable merge when database is locked [#1975]
- Fix intermittent crashes with favorite icon downloads [#1980]
- Provide potential crash warning to Qt 5.5.x users [#2211]
- Disable apply button when creating new entry/group to prevent data loss [#2204]
- Allow for 12 hour timeout to lock idle database [#2173]
- Multiple SSH Agent fixes [#1981, #2117]
- Multiple Browser Integration enhancements [#1993, #2003, #2055, #2116, #2159, #2174, #2185]
- Fix browser proxy application not closing properly [#2142]
- Add real names and Patreon supporters to about dialog [#2214]
- Add settings button to toolbar, Donate button, and Report a Bug button to help menu [#2214]
- Enhancements to release-tool to appsign intermediate build products [#2101]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants