Fix occasional crash when favicon progress dialog is closed #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed progress dialog to a true percentage calculation * Removed some unnecessary code
hifi
approved these changes
May 20, 2018
phoerious
approved these changes
May 20, 2018
src/gui/EditWidgetIcons.cpp
Outdated
| setMinimumSize(QSize(400, 75)); | ||
| } | ||
|
|
||
| void UrlFetchProgressDialog::networkReplyProgress(qint64 bytesRead, qint64 totalBytes) | ||
| { | ||
| setMaximum(totalBytes); | ||
| setValue(bytesRead); | ||
| setValue(static_cast<int>(bytesRead/totalBytes)); |
There was a problem hiding this comment.
Space around division operator.
droidmonkey
added a commit
that referenced
this pull request
Aug 22, 2018
- Show all URL schemes in entry view [#1768] - Disable merge when database is locked [#1975] - Fix intermittent crashes with favorite icon downloads [#1980] - Provide potential crash warning to Qt 5.5.x users [#2211] - Disable apply button when creating new entry/group to prevent data loss [#2204] - Allow for 12 hour timeout to lock idle database [#2173] - Multiple SSH Agent fixes [#1981, #2117] - Multiple Browser Integration enhancements [#1993, #2003, #2055, #2116, #2159, #2174, #2185] - Fix browser proxy application not closing properly [#2142] - Add real names and Patreon supporters to about dialog [#2214] - Add settings button to toolbar, Donate button, and Report a Bug button to help menu [#2214] - Enhancements to release-tool to appsign intermediate build products [#2101]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1936
Also removes some unnecessary code and changes the progress to a true percentage.
Motivation and context
Crashes are bad, mm'kay.
How has this been tested?
Manually
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]