Use Chrome registry settings with Vivaldi #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
requested changes
Aug 3, 2018
src/browser/BrowserOptionDialog.cpp
Outdated
| #ifdef Q_OS_WIN | ||
| // Vivaldi uses Chrome's registry settings | ||
| m_ui->vivaldiSupport->setChecked(false); | ||
| m_ui->vivaldiSupport->setEnabled(false); |
There was a problem hiding this comment.
Perhaps we should hide it instead of just disabling it.
There was a problem hiding this comment.
That would be better, yes.
droidmonkey
approved these changes
Aug 4, 2018
droidmonkey
added a commit
that referenced
this pull request
Aug 22, 2018
- Show all URL schemes in entry view [#1768] - Disable merge when database is locked [#1975] - Fix intermittent crashes with favorite icon downloads [#1980] - Provide potential crash warning to Qt 5.5.x users [#2211] - Disable apply button when creating new entry/group to prevent data loss [#2204] - Allow for 12 hour timeout to lock idle database [#2173] - Multiple SSH Agent fixes [#1981, #2117] - Multiple Browser Integration enhancements [#1993, #2003, #2055, #2116, #2159, #2174, #2185] - Fix browser proxy application not closing properly [#2142] - Add real names and Patreon supporters to about dialog [#2214] - Add settings button to toolbar, Donate button, and Report a Bug button to help menu [#2214] - Enhancements to release-tool to appsign intermediate build products [#2101]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Under Windows Vivaldi browser is using Chrome registry settings for reading native messaging settings. When on Windows, user can select only three browser options, and "Chrome" has been changed to "Chrome and Vivaldi".
Motivation and context
Fixes #1943.
Fixes keepassxreboot/keepassxc-browser#48.
How has this been tested?
Manually.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]