Custom icons duplicated

[louib]

Custom icons for the same website are added multiple times.

Expected Behavior

We should at least try to detect duplicates and not fetch the icon multiple times for the same website.

Current Behavior

Custom icons for the same website are added multiple times.

Steps to Reproduce (for bugs)

1. Add entry with a website
2. Click Download favicon multiple times.

Context

I was trying to reproduce #225

Your Environment

• KeePassXC version/commit used: 6409661
• Qt version: Qt 5.7.1
• Operating System and version: MacOS 10.11.16

[droidmonkey]

Would you match the base url only? Some sites have different icons for sub domains.

[louib]

@droidmonkey this and making sure clicking multiple times download from within the window just fetches the icon 1 time.

[paolostivanin]

Maybe by comparing the checksum? I think it's always the same if the icon is the same (haven't tried).
Could be worth a try though :)

[droidmonkey]

That's a good idea although it would be best to precalculate and store the checksum/hash in the db somehow.

[paolostivanin]

Something like an hash table maybe?

{ 
   google.com:
      { icon: favicon.ico,
        cks: checksum
      },
   gmail.google.com:
      { icon: favicon.ico,
        cks: checksum
      },
}

[phoerious]

Why not use the icons themselves as keys? We could use a QHash map and provide a qHash() implementation for icon data.

[paolostivanin]

Yep, good idea!