Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for deleting a custom favicon used by multiple entries #356

Closed
matthewdavis opened this issue Feb 27, 2017 · 3 comments · Fixed by #357
Closed

Allow for deleting a custom favicon used by multiple entries #356

matthewdavis opened this issue Feb 27, 2017 · 3 comments · Fixed by #357
Assignees
Milestone

Comments

@matthewdavis
Copy link

Expected Behavior

When attempting to delete a custom favicon the message "Can't delete icon. Still used by $X items" is displayed. Maybe make the '$x items' a link to the found items.

Context

Reasons for this feature request are as follows

  • Because when I clicked download favicon, if one is not found a default icon is used for that site. And because Custom icons duplicated #232 still exists, numerous 'default' icons have populated my custom favicon list. I wasn't aware of the fact they were all using default icons until now and cannot clean them up since the icons have no perceived link to a given site.

  • Also I'm OCD and don't like the duplicate icons in there.

Your Environment

  • KeePassXC version/commit used: Version 2.1.2 Revision: 0f1c518
  • Qt version (e.g. Qt 5.3): Qt 5.7.1
  • Operating System and version: Fedora 25 (Workstation Edition)
    CPU architecture: x86_64
    Kernel: linux 4.9.11-200.fc25.x86_64
@droidmonkey
Copy link
Member

A group can also have an icon assigned to it. This might be easier to implement by changing it to a question instead of an error.

"This icon is used by X entries, and will be replaced with the default icon if deleted. Are you sure you want to remove it?"

If you click yes it will take the enumerated entries and replace the icon with the default then delete the custom icon.

Perhaps an even better option would be to allow merging/replacing icons with another.

@droidmonkey droidmonkey changed the title Allow for identifying what site is using a custom favicon Allow for deleting a custom favicon used by multiple entries Feb 28, 2017
@droidmonkey
Copy link
Member

I posted a fix, see if this fits your needs.

@matthewdavis
Copy link
Author

matthewdavis commented Feb 28, 2017

Just tested it and it worked great. Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants