Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the dimensions of custom icons from 16x16 to 128x128 #904

Closed
guihkx opened this issue Aug 29, 2017 · 3 comments
Closed

Increase the dimensions of custom icons from 16x16 to 128x128 #904

guihkx opened this issue Aug 29, 2017 · 3 comments
Assignees
Milestone

Comments

@guihkx
Copy link
Contributor

guihkx commented Aug 29, 2017

What do you guys think about that? KeePass does it by default. 16x16 icons look pixelated when viewing the database on KeePass2Android:

screenshot_20170829-012816

The first and penultimate icons are 16x16, while all the others are 128x128.

Thank you.

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Aug 29, 2017

Have you used the favicon downloader to download those 2 icon?

@guihkx
Copy link
Contributor Author

guihkx commented Aug 29, 2017

No, I've downloaded those logos in a higher resolution using Google Images, then I've added them to KPXC, but they were resized to 16x16.

m_database->metadata()->addCustomIcon(uuid, image.scaled(16, 16));

I guess that is the relevant piece of code that handles icons?

@droidmonkey
Copy link
Member

That would be it. Good suggestion

@phoerious phoerious added this to the v2.3.0 milestone Aug 29, 2017
@droidmonkey droidmonkey self-assigned this Sep 4, 2017
@droidmonkey droidmonkey changed the title [Suggestion] Increase the dimensions of custom icons from 16x16 to 128x128 Increase the dimensions of custom icons from 16x16 to 128x128 Sep 10, 2017
@droidmonkey droidmonkey modified the milestones: v2.3.0, v2.2.1 Sep 24, 2017
droidmonkey added a commit that referenced this issue Sep 24, 2017
* Fixes #904, icons are saved at or below 128x128
* Fixes #403, crash occurs due to dialog on non-gui thread
* Fixes #232, icon hashes calculated and compared against
droidmonkey added a commit that referenced this issue Sep 27, 2017
* Fixes #904, icons are saved at or below 128x128
* Fixes #403, crash occurs due to dialog on non-gui thread
* Fixes #232, icon hashes calculated and compared against
droidmonkey added a commit that referenced this issue Sep 29, 2017
* Fixes #904, icons are saved at or below 128x128
* Fixes #403, crash occurs due to dialog on non-gui thread
* Fixes #232, icon hashes calculated and compared against
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants