add ignoreNullValues for AWS CloudWatch Scaler #5635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Pickerill <[email protected]>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
from
13c0fec
to
53ea3fd
Compare
Signed-off-by: Rob Pickerill <[email protected]>
Signed-off-by: Rob Pickerill <[email protected]>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
3 times, most recently
from
495c201
to
8e41311
Compare
Signed-off-by: Rob Pickerill <[email protected]>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
from
584eba6
to
b0d4e84
Compare
JorTurFer
reviewed
Mar 30, 2024
Signed-off-by: Rob Pickerill <[email protected]>
Signed-off-by: Rob Pickerill <[email protected]>
Signed-off-by: Rob Pickerill <[email protected]>
7 tasks
robpickerill
changed the title
|
I added end to end tests here for both minMetricValue and errorWhenNullValues to cover off both scenarios. I need to tidy them up a little, which ill do over the next few days. |
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
2 times, most recently
from
53fac56
to
0ef98c5
Compare
Signed-off-by: Rob Pickerill <[email protected]>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
from
0ef98c5
to
0b61f97
Compare
Signed-off-by: Rob Pickerill <[email protected]>
Signed-off-by: Rob Pickerill <[email protected]>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
from
68a1c71
to
0dc9b77
Compare
robpickerill
commented
Apr 4, 2024
...calers/aws/aws_cloudwatch_min_value_null_values/aws_cloudwatch_min_value_null_values_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Rob Pickerill <[email protected]>
robpickerill
changed the title
Signed-off-by: Rob Pickerill <[email protected]>
robpickerill
commented
Apr 13, 2024
|
I was discussing with Jorge on slack to get the e2e tests re-ran, as the failures were upstream issues: https://kubernetes.slack.com/archives/C01JGDP8MB8/p1717129850310929?thread_ts=1715943304.582119&cid=C01JGDP8MB8 However, since then the changes for the validation have gone in, so let me fix up the conflicts here over the weekend, and then let's get e2e passing again on this branch |
|
Thanks! |
Signed-off-by: robpickerill <[email protected]>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
from
731d45c
to
2e76a9b
Compare
|
Fixed conflicts, this needs another e2e test run |
|
/run-e2e aws |
zroubalik
reviewed
Jun 10, 2024
Fixed, all tests should pass now. I see e2e didn't run due to Azure cluster scaling actions failing, would it be easier for me to put the e2e tests in a different PR and unblock this PR? The unit tests here cover the error case for the scaler, but I wanted to add e2e to prove the backward compatibility for the change. Let me know what works best for you. |
Signed-off-by: robpickerill <[email protected]>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
from
48ccb91
to
43a2c3f
Compare
|
/run-e2e aws |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
/run-e2e aws |
|
Thanks Jorge, need anything else to merge this? |
stale
bot
removed
the
stale
Signed-off-by: Rob Pickerill <[email protected]>
JorTurFer
approved these changes
Aug 19, 2024
|
Thanks Jorge, fixed up the docs, and merged main into here and docs, should be good to go now - thanks again! |
|
/run-e2e aws |
JorTurFer
reviewed
Aug 20, 2024
1 task
fira42073
pushed a commit
to fira42073/keda
that referenced
this pull request
Aug 25, 2024
* add errorWhenMetricValueEmpty Signed-off-by: Rob Pickerill <[email protected]> * fix golangci-lint Signed-off-by: Rob Pickerill <[email protected]> * improve error message for empty results Signed-off-by: Rob Pickerill <[email protected]> * add error when empty metric values to changelog Signed-off-by: Rob Pickerill <[email protected]> * rename errorWhenMetricValuesEmpty -> errorWhenNullValues Signed-off-by: Rob Pickerill <[email protected]> * use getParameterFromConfigV2 to read config for errorWhenNullValues Signed-off-by: Rob Pickerill <[email protected]> * add e2e for error state for cw, and improve e2e for min values for cw Signed-off-by: Rob Pickerill <[email protected]> * remove erroneous print statement Signed-off-by: Rob Pickerill <[email protected]> * remove unused vars Signed-off-by: Rob Pickerill <[email protected]> * rename errorWhenMetricValuesEmpty -> ignoreNullValues Signed-off-by: Rob Pickerill <[email protected]> * move towards shared package for e2e aws Signed-off-by: Rob Pickerill <[email protected]> * minMetricValue optionality based on ignoreNullValues Signed-off-by: Rob Pickerill <[email protected]> * fail fast Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * Update tests/scalers/aws/aws_cloudwatch_ignore_null_values_false/aws_cloudwatch_ignore_null_values_false_test.go Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * Apply suggestions from code review Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * fail fast Signed-off-by: Rob Pickerill <[email protected]> * fix broken new line Signed-off-by: Rob Pickerill <[email protected]> * fix broken new lines Signed-off-by: Rob Pickerill <[email protected]> * assert no scaling changes in e2e, and set false for required in minMetricValue Signed-off-by: robpickerill <[email protected]> * fix ci checks Signed-off-by: robpickerill <[email protected]> * Update tests/scalers/aws/aws_cloudwatch_min_metric_value/aws_cloudwatch_min_metric_value_test.go fix invalid check Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * fix merge conflicts Signed-off-by: robpickerill <[email protected]> * fix e2e package names Signed-off-by: robpickerill <[email protected]> --------- Signed-off-by: Rob Pickerill <[email protected]> Signed-off-by: robpickerill <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Fira Curie <[email protected]>
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
Oct 7, 2024
* add errorWhenMetricValueEmpty Signed-off-by: Rob Pickerill <[email protected]> * fix golangci-lint Signed-off-by: Rob Pickerill <[email protected]> * improve error message for empty results Signed-off-by: Rob Pickerill <[email protected]> * add error when empty metric values to changelog Signed-off-by: Rob Pickerill <[email protected]> * rename errorWhenMetricValuesEmpty -> errorWhenNullValues Signed-off-by: Rob Pickerill <[email protected]> * use getParameterFromConfigV2 to read config for errorWhenNullValues Signed-off-by: Rob Pickerill <[email protected]> * add e2e for error state for cw, and improve e2e for min values for cw Signed-off-by: Rob Pickerill <[email protected]> * remove erroneous print statement Signed-off-by: Rob Pickerill <[email protected]> * remove unused vars Signed-off-by: Rob Pickerill <[email protected]> * rename errorWhenMetricValuesEmpty -> ignoreNullValues Signed-off-by: Rob Pickerill <[email protected]> * move towards shared package for e2e aws Signed-off-by: Rob Pickerill <[email protected]> * minMetricValue optionality based on ignoreNullValues Signed-off-by: Rob Pickerill <[email protected]> * fail fast Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * Update tests/scalers/aws/aws_cloudwatch_ignore_null_values_false/aws_cloudwatch_ignore_null_values_false_test.go Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * Apply suggestions from code review Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * fail fast Signed-off-by: Rob Pickerill <[email protected]> * fix broken new line Signed-off-by: Rob Pickerill <[email protected]> * fix broken new lines Signed-off-by: Rob Pickerill <[email protected]> * assert no scaling changes in e2e, and set false for required in minMetricValue Signed-off-by: robpickerill <[email protected]> * fix ci checks Signed-off-by: robpickerill <[email protected]> * Update tests/scalers/aws/aws_cloudwatch_min_metric_value/aws_cloudwatch_min_metric_value_test.go fix invalid check Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * fix merge conflicts Signed-off-by: robpickerill <[email protected]> * fix e2e package names Signed-off-by: robpickerill <[email protected]> --------- Signed-off-by: Rob Pickerill <[email protected]> Signed-off-by: robpickerill <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for erroring the AWS Cloudwatch Scaler when the GetMetricData call returns an empty set of metrics, resulting in no scale-changing behaviour when no custom metrics are available during the Cloudwatch query window.
Checklist
Fixes #5352
Relates to: