Move to getParameterFromConfigV2 for input, excluding auth

[robpickerill]

Moves the AWS CloudWatch scaler to use getParameterFromConfigV2 for input.

Context is from a conversation started here: #5635 (comment)

There is one TODO here, which is to move authorization over. I'll present that in a separate PR to avoid a large PR landing, and I can spend more time to read through the authorization code.

Checklist

• When introducing a new scaler, I agree with the scaling governance policy
• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

[JorTurFer]

LGTM! Nice improvement!
PTAL @dttung2905

[JorTurFer]

/run-e2e cloudwatch
Update: You can check the progress here

[dttung2905]

Sorry I will try to take a look tomorrow morning😬

[JorTurFer]

@robpickerill ,
Could you fix DCO check? You have the resolution steps clicking in the link

[dttung2905]

Hi @robpickerill,

First of all, thank you so much for putting in effort into making this PR. Generally, its LGTM. Just one minor point that we have another PR #5319 that changes how getParameterFromConfigV2 works.

Is this PR blocking the other PR #5635 ? We can either:

(1) wait for #5319 to be merged first , then this PR and #5635 or

(2) we move forward with this current implementation of getParameterFromConfigV2 in the main branch. I will rebase yours into #5319

WDYT? @JorTurFer I'm in favour of (1) and I will try my best to merge my PR. Its almost done tbh :D

[robpickerill]

Hi @robpickerill,

First of all, thank you so much for putting in effort into making this PR. Generally, its LGTM. Just one minor point that we have another PR #5319 that changes how getParameterFromConfigV2 works.

Is this PR blocking the other PR #5635 ? We can either:

(1) wait for #5319 to be merged first , then this PR and #5635 or

(2) we move forward with this current implementation of getParameterFromConfigV2 in the main branch. I will rebase yours into #5319

WDYT? @JorTurFer I'm in favour of (1) and I will try my best to merge my PR. Its almost done tbh :D

Thanks @dttung2905, by all means take option 1 for me, feel free to tag me in the updates for when you finalize the implementation and I'll refactor this PR as needed.

Also let me know if I can do anything to help, thanks again!

[JorTurFer]

Let's wait with this and then rebase it if you agree

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[zroubalik]

@dttung2905 we can close this, right?

[dttung2905]

@dttung2905 we can close this, right?

Yes we can

[zroubalik]

@dttung2905 we can close this, right?

Yes we can

Thanks for the work anyway!